Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_uniform_random fix. #83

Merged
merged 1 commit into from
Aug 9, 2021
Merged

test_uniform_random fix. #83

merged 1 commit into from
Aug 9, 2021

Conversation

mdavis36
Copy link
Collaborator

@mdavis36 mdavis36 commented Aug 5, 2021

Fixes for test_uniform_random. Adding a couple of missing default values necessary and small fixes in the class.

@mdavis36 mdavis36 requested a review from jmikeowen August 5, 2021 00:54
jmikeowen
jmikeowen approved these changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@jmikeowen jmikeowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine -- though I think these changes are already rolled into the Neighbor test fix pull request.

@jmikeowen jmikeowen merged commit 57b7c8f into develop Aug 9, 2021
@mdavis36 mdavis36 deleted the bugfix/test_uniform_random branch August 9, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdavis36 @jmikeowen