Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pmin damage #99

Merged
merged 7 commits into from
Oct 21, 2021
Merged

Feature/pmin damage #99

merged 7 commits into from
Oct 21, 2021

Conversation

jmikeowen
Copy link
Collaborator

This brings in a few changes:

  • Most importantly, I've added a new member to SolidEquationOfState (minimumPressureDamage), which is the minimum pressure that damaged material should support. This replaces the old binary flag in solid hydros (negativePressureInDamage), so that flag has been removed. This new variable is the minimum pressure that should be allowed for fully damaged material, and defaults to 0.0 (i.e., no tension is allowed). This allows us more control over the new feature in the code where damaged material is able to maintain strength properties, rather than behaving purely as a fluid.
  • I found that the ANEOS third party library comes with three provided material inputs (quartz, dunnite, and serpentine), so I've added a convenient constructor for ANEOS that allows the user to specify one of those in concise syntax. I also modified the aneos.cmake TPL build prescription to install these pre-packaged inputs, and have updated the TOSS gcc 8.1/8.3 pre-built LC third party installs accordingly.
  • I improved some of our Python "shadow" code (factory functions that present a nicer Python front-end to the user), including stuff that now preserves the C++ pybind11 documentation in the help() for such functions. We really need to package up these sorts of utilities into something designed to standardize writing shadow interfaces like this, since this is a nice method of quickly giving users a much friendlier interface to the code.

@jmikeowen
Copy link
Collaborator Author

Spoke with Paul and he's good to go with these changes.

@jmikeowen jmikeowen merged commit 282a3e6 into develop Oct 21, 2021
@jmikeowen jmikeowen deleted the feature/Pmin-damage branch October 21, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants