Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip/Fix AMD Verify Build Error #511

Closed
wants to merge 12 commits into from
Closed

Skip/Fix AMD Verify Build Error #511

wants to merge 12 commits into from

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Feb 8, 2024

Description

Should allow the GitHub CI to build for the AMD system and potentially progress further.
I expect this to fail at ESMI now...but will depend on whether the AMD node has this available.

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please provide hardware architecture specs and
instructions so we can reproduce.

  • Test A: Hardware architecture, machine name, example/test run
  • Test B: Hardware architecture, machine name, example/test run
  • ...

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

@tpatki tpatki added the status-work-in-progress In progress, not ready to merge. label Feb 8, 2024
@tpatki tpatki changed the title Bypass checking for AMD model to support GitHub CI test Skip/Fix AMD Verify Build Error Feb 9, 2024
@tpatki
Copy link
Member Author

tpatki commented Feb 22, 2024

Closing this PR based on the discussion with @slabasan. HSMP is not supported on many systems, so we don't currently have the resources to figure out AMD builds outside of HSMP.

@tpatki tpatki closed this Feb 22, 2024
@slabasan slabasan deleted the add_new_amd_arch branch March 1, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-work-in-progress In progress, not ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant