Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for ROCm 6.0.2 and new RSMI APIs. #512

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Updates for ROCm 6.0.2 and new RSMI APIs. #512

merged 3 commits into from
Feb 10, 2024

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Feb 9, 2024

Description

ROCm RSMI interfaces have changed and previous versions are not supported on LC systems. This PR will update to the newer versions and also ensure backward compatibility for other users.

Fixes #487.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

Applies to AMD GPUs only.

  • Corona
  • Tioga

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

Thank you for taking the time to contribute to Variorum!

@tpatki tpatki added this to the Production: v0.8.0 Release milestone Feb 9, 2024
@tpatki tpatki self-assigned this Feb 9, 2024
@tpatki tpatki added status-ready-for-review Formatted, and tested on multiple systems. status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch labels Feb 10, 2024
@tpatki tpatki merged commit 192a58d into dev Feb 10, 2024
13 of 16 checks passed
@slabasan slabasan deleted the rsmi_6_0_2_fixes branch February 16, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-ready-for-review Formatted, and tested on multiple systems. status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU Print power example error on tioga
1 participant