Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Juno r2 code to build with -DENABLE_WARNINGS=ON #528

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

tpatki
Copy link
Member

@tpatki tpatki commented Mar 11, 2024

Description

Addresses several -Werror=format and -Werror=unused-variable` on Juno r2, but doesn't fix #526 yet.

Fixes #527.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/architecture support (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Build/CI update

How Has This Been Tested?

  • Juno r2

Checklist:

  • I have run ./scripts/check-code-format.sh and confirm my code code follows the style guidelines of variorum
  • I have added comments in my code
  • My changes generate no new warnings (build with -DENABLE_WARNINGS=ON)
  • New and existing unit tests pass with my changes

@tpatki tpatki added this to the Production: v0.8.0 Release milestone Mar 11, 2024
@tpatki tpatki added the status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch label Mar 11, 2024
@tpatki tpatki merged commit c4c2cc3 into dev Mar 11, 2024
15 checks passed
@slabasan slabasan deleted the fix_warnings_on_junor2 branch March 12, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status-ready-to-merge This PR has made all revisions and is ready to merge into the develop branch
Projects
None yet
1 participant