Skip to content

Commit

Permalink
Lv2ControlBase: Remove unused virtuals
Browse files Browse the repository at this point in the history
They were never used. Possibly they were just in the code because the
code originated from #4662 (where the virtuals would also be
omittable...).
  • Loading branch information
JohannesLorenz committed Feb 21, 2023
1 parent 9bcf63c commit 7649f5e
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 42 deletions.
5 changes: 0 additions & 5 deletions include/Lv2ControlBase.h
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,6 @@ class LMMS_EXPORT Lv2ControlBase : public LinkedModelGroups
const class TimePos &time, f_cnt_t offset);

private:
//! Return the DataFile settings type
virtual DataFile::Types settingsType() = 0;
//! Inform the plugin about a file name change
virtual void setNameFromFile(const QString &fname) = 0;

//! Independent processors
//! If this is a mono effect, the vector will have size 2 in order to
//! fulfill LMMS' requirement of having stereo input and output
Expand Down
16 changes: 0 additions & 16 deletions plugins/Lv2Effect/Lv2FxControls.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,20 +86,4 @@ void Lv2FxControls::changeControl() // TODO: what is that?
}




DataFile::Types Lv2FxControls::settingsType()
{
return DataFile::EffectSettings;
}




void Lv2FxControls::setNameFromFile(const QString &name)
{
effect()->setDisplayName(name);
}


} // namespace lmms
3 changes: 0 additions & 3 deletions plugins/Lv2Effect/Lv2FxControls.h
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,6 @@ private slots:
void changeControl();

private:
DataFile::Types settingsType() override;
void setNameFromFile(const QString &name) override;

friend class gui::Lv2FxControlDialog;
friend class Lv2Effect;
};
Expand Down
16 changes: 0 additions & 16 deletions plugins/Lv2Instrument/Lv2Instrument.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -196,25 +196,9 @@ QString Lv2Instrument::nodeName() const



DataFile::Types Lv2Instrument::settingsType()
{
return DataFile::InstrumentTrackSettings;
}




void Lv2Instrument::setNameFromFile(const QString &name)
{
instrumentTrack()->setName(name);
}



namespace gui
{


/*
Lv2InsView
*/
Expand Down
2 changes: 0 additions & 2 deletions plugins/Lv2Instrument/Lv2Instrument.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ private slots:

private:
QString nodeName() const override;
DataFile::Types settingsType() override;
void setNameFromFile(const QString &name) override;

#ifdef LV2_INSTRUMENT_USE_MIDI
std::array<int, NumKeys> m_runningNotes = {};
Expand Down

0 comments on commit 7649f5e

Please sign in to comment.