Skip to content

Commit

Permalink
Code review changes (#6548)
Browse files Browse the repository at this point in the history
Add a space after some while loops. Fix a typo in a comment.
  • Loading branch information
michaelgregorius committed Aug 11, 2023
1 parent 4f01094 commit dac1f77
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/core/DataFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1699,7 +1699,7 @@ static PatternAnalysisResult analyzeAutomationPattern(QDomElement const & automa

// Iterate the objects. These contain the ids of the automated objects.
QDomElement object = automationPattern.firstChildElement("object");
while(!object.isNull())
while (!object.isNull())
{
unsigned int const id = object.attribute("id").toUInt();

Expand Down Expand Up @@ -1788,7 +1788,7 @@ static void fixInstrumentBaseNoteAndCollectIds(QDomElement & instrument, std::se
static void fixAutomationPattern(QDomElement & automationPattern)
{
QDomElement time = automationPattern.firstChildElement("time");
while(!time.isNull())
while (!time.isNull())
{
// Automation patterns can automate base notes as floats
// so we read and correct them as floats here.
Expand Down Expand Up @@ -1823,7 +1823,7 @@ static void fixTrack(QDomElement & track, std::set<unsigned int> & automatedBase

Track::TrackTypes const trackType = static_cast<Track::TrackTypes>(track.attribute("type").toInt());

// BB tracks need special handling because they container a track container of their own
// BB tracks need special handling because they contain a track container of their own
if (trackType == Track::PatternTrack)
{
// Assuming that a BB track cannot contain another BB track here...
Expand Down Expand Up @@ -1948,7 +1948,7 @@ static void fixAutomationTracks(QDomElement & song, std::set<unsigned int> const
{
// The pattern itself is mixed. Remove the base note objects.
QDomElement object = automationPattern.firstChildElement("object");
while(!object.isNull())
while (!object.isNull())
{
unsigned int const id = object.attribute("id").toUInt();

Expand Down Expand Up @@ -1978,7 +1978,7 @@ static void fixAutomationTracks(QDomElement & song, std::set<unsigned int> const
{
// This pattern has base note automations. Remove all other ones and fix the pattern.
QDomElement object = automationPattern.firstChildElement("object");
while(!object.isNull())
while (!object.isNull())
{
unsigned int const id = object.attribute("id").toUInt();

Expand Down

0 comments on commit dac1f77

Please sign in to comment.