Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMMS needs default guis #1713

Closed
Reaper10 opened this issue Jan 28, 2015 · 13 comments
Closed

LMMS needs default guis #1713

Reaper10 opened this issue Jan 28, 2015 · 13 comments

Comments

@Reaper10
Copy link

LMMS needs default guis beause I have plugins with a lot of controls but there is no way to get to them.
Ie when I load the in a fx box there is controls button to click on.

@tresf
Copy link
Member

tresf commented Jan 28, 2015

Please retitle, reword, provide an example as well as steps to reproduce and reopen. We've warned you about the quality of these bug reports several times before.

@tresf tresf closed this as completed Jan 28, 2015
@unfa
Copy link
Contributor

unfa commented Jan 28, 2015

LMMS provides GUI for LADSPA plugins. And there is a button to access them.
Could you drop in a screenshot?
28 sty 2015 18:01 "Reaper10" notifications@github.com napisał(a):

LMMS needs default guis beause I have plugins with a lot of controls but
there is no way to get to them.
Ie when I load the in a fx box there is controls button to click on.


Reply to this email directly or view it on GitHub
#1713.

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

A valid issue though is that our LADSPA interface do not describe very well what some controls are.

Example. on CALF Vintage Delay you can select the mix type, this is the LV2 interface:

2015-01-28-191125_1920x1080_scrot

The LADSPA interface on LMMS:

2015-01-28-191340_1920x1080_scrot

What's mix type 1? And 2, 3, 4?

I don't know if LADSPA exposes this information, and we should refer to this in another issue, was just commenting that always bothered me...

@tresf
Copy link
Member

tresf commented Jan 28, 2015

I don't know if LADSPA exposes this information, and we should refer to this in another issue, was just commenting that always bothered me...

IIRC LADSPA has no GUI interface available. If that is what the OP is describing then this is a duplicate of #562.

@tresf
Copy link
Member

tresf commented Jan 28, 2015

That said, I agree we can automagically interpolate some better GUI components for LADSPA.

@badosu
Copy link
Contributor

badosu commented Jan 28, 2015

@tresf

IIRC LADSPA has no GUI interface available.

I am aware of that, what I am saying is exposing that the value 1 for the mixer type has the label "Ping-Pong" on our interface. If LADSPA enables this, we should totally do it.

@Reaper10
Copy link
Author

oh sorry they are vst plugngs

@tresf
Copy link
Member

tresf commented Jan 29, 2015

oh sorry they are vst plugngs

Oh sorry your bug report is closed until you fix it. 🍺

If LADSPA enables this, we should totally do it.

Hmm... The Calf plugins have them defined the metada code, but I've no idea how to programatically cherry-pick them or if this is even normal LADSPA API . plugins/LadspaEffect/calf/src/metadata.cpp#L145

Some googling shows that RDF files are the desired approach, which some of our LADSPA plugins do have bundled. Shall we file an enhancement for an LADSPA RDF parsing/GUI support?

@badosu
Copy link
Contributor

badosu commented Jan 29, 2015

@tresf

Hmm... The Calf plugins have them defined the metada code, but I've no idea how to programatically cherry-pick them or if this is even normal LADSPA API . plugins/LadspaEffect/calf/src/metadata.cpp#L145

Great find!

Some googling shows that RDF files are the desired approach, which some of our LADSPA plugins do have bundled. Shall we file an enhancement for an LADSPA RDF parsing/GUI support?

Totally! Imagine two producers collaborating:

  • So, I love vintage delay, I use it on Ardour all the time
  • Yeah me, too, I use it on LMMS via LADSPA
  • Cool! I just love it's Ping-Pong mode running as a Tape! Which mode do you use?
  • Huh? Type 1 with Medium 2?

If we could fix this, it would be amazing!

@tresf
Copy link
Member

tresf commented Jan 29, 2015

Great. We should crawl Ardour code to see if we can steal some of their code. From what I can see, they are GPL2 just like us.

I'll file the enhancement now. In terms of the Calf stuff, we may have to write our own RDFs for them to display properly, but a few XML files would probably be worth it.

@badosu
Copy link
Contributor

badosu commented Jan 29, 2015

@tresf They have LADSPA support as far as I know, but if we already know where the information is, I don't think we need to take a look at their code.

@tresf
Copy link
Member

tresf commented Jan 29, 2015

I don't think we need to take a look at their code.

Yeah, its not helping much lol. I've created a new bug report... #1717

@badosu
Copy link
Contributor

badosu commented Jan 29, 2015

@tresf Sorry :-). Thanks for the research, really nice work! I was reading http://www.ladspa.org/ladspa_sdk/ladspa.h.txt instead, I guess your approach was better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants