Mixer volume percentage labels are off by a factor of 100

[Wallacoloo]

See the below screenshot. When I right click on the volume slider for a channel in the mixer, the options like "copy value" all display something like "1.25%" when the channel is really at 125% volume:

Edit: The channel send knobs are also bugged in the same way.

I've checked the other areas of the program and found some other discrepencies:

• The master volume slider at the top of the window does not include the "%" unit in the right-click context menu (though it does include it for the tooltip when editing). That is, volume readouts are just "100", or "85", rather than "85%".
• The master pitch reports no units in the context menu, though it too includes units in the tooltip. In contrast, the instrument-specific pitch knobs do include units.

[Wallacoloo]

Just starting work on a patch for this.

[Wallacoloo]

This doesn't appear to be the trivial fix I thought it would be.
It appears that the context menus are generated in AutomatableModelView::addDefaultActions, which looks like:

void AutomatableModelView::addDefaultActions( QMenu* menu )
{
    AutomatableModel* model = modelUntyped();
    // ...
    menu->addAction( embed::getIconPixmap( "edit_copy" ),
                    AutomatableModel::tr( "&Copy value (%1%2)" ).
                        arg( model->displayValue( model->value<float>() ) ).
                        arg( m_unit ),
                    model, SLOT( copyValue() ) );
// ...

Model::displayValue looks like:

QString AutomatableModel::displayValue( const float val ) const
{
    switch( m_dataType )
    {
        case Float: return QString::number( castValue<float>( scaledValue( val ) ) );
        case Integer: return QString::number( castValue<int>( scaledValue( val ) ) );
        case Bool: return QString::number( castValue<bool>( scaledValue( val ) ) );
    }
    return "0";
}

And finally, Model::scaledValue is as below:

float AutomatableModel::scaledValue( float value ) const
{
    return m_scaleType == Linear
        ? value
        : logToLinearScale<float>( ( value - minValue<float>() ) / m_range );
}

The Fader's volume model stores its volume as a proportion. It doesn't appear that there currently exists any way to have the view to show that value multiplied by 100.

Curiously, the Knob class is also used to report volume, but seems to have found a way around this issue. From the looks of it, it may actually be storing the model itself in units of percent, but I cannot tell.

[StCyr]

Hello,

AutomatableModel::displayValue is only used here:

cyr@opennms-dev:~/lmms/src$ grep -R displayValue *
core/AutomatableModel.cpp:QString AutomatableModel::displayValue( const float val ) const
gui/widgets/Knob.cpp:           s_textFloat->setText( displayValue() );
gui/widgets/Knob.cpp:   s_textFloat->setText( displayValue() );
gui/widgets/Knob.cpp:   s_textFloat->setText( displayValue() );
gui/widgets/Knob.cpp:QString Knob::displayValue() const
gui/editors/AutomationEditor.cpp:                                               ->displayValue( level[i] );
gui/editors/AutomationEditor.cpp:                                                       ->displayValue( level );
gui/AutomatableModelView.cpp:                                                   arg( model->displayValue( model->initValue<float>() ) ).
gui/AutomatableModelView.cpp:                                                   arg( model->displayValue( model->value<float>() ) ).
gui/AutomatableModelView.cpp:                                                   arg( model->displayValue( AutomatableModel::copiedValue() ) ).

Actually the Knob class uses its own displayValue function. So, in the end, AutomatableModel::displayValue is only used within gui/AutomatableModelView.cpp and gui/editors/AutomationEditor.cpp.

I just made a trivial patch which seems to solve the issue.

diff --git a/src/core/AutomatableModel.cpp b/src/core/AutomatableModel.cpp
index bf56285..8b0a5bb 100644
--- a/src/core/AutomatableModel.cpp
+++ b/src/core/AutomatableModel.cpp
@@ -269,8 +269,8 @@ QString AutomatableModel::displayValue( const float val ) const
 {
        switch( m_dataType )
        {
-               case Float: return QString::number( castValue<float>( scaledValue( val ) ) );
-               case Integer: return QString::number( castValue<int>( scaledValue( val ) ) );
+               case Float: return QString::number( castValue<float>( scaledValue( val ) * 100 ) );
+               case Integer: return QString::number( castValue<int>( scaledValue( val ) * 100 ) );
                case Bool: return QString::number( castValue<bool>( scaledValue( val ) ) );
        }
        return "0";
diff --git a/src/gui/editors/AutomationEditor.cpp b/src/gui/editors/AutomationEditor.cpp
index b719063..675af77 100644
--- a/src/gui/editors/AutomationEditor.cpp
+++ b/src/gui/editors/AutomationEditor.cpp
@@ -1044,7 +1044,7 @@ void AutomationEditor::paintEvent(QPaintEvent * pe )
                        for( int i = 0; i < 2; ++i )
                        {
                                const QString & label = m_pattern->firstObject()
-                                               ->displayValue( level[i] );
+                                               ->displayValue( level[i] /100 );
                                p.setPen( QApplication::palette().color( QPalette::Active,
                                                        QPalette::Shadow ) );
                                p.drawText( 1, y[i] - font_height + 1,
@@ -1072,7 +1072,7 @@ void AutomationEditor::paintEvent(QPaintEvent * pe )
                        for( ; level <= m_topLevel; level += printable )
                        {
                                const QString & label = m_pattern->firstObject()
-                                                       ->displayValue( level );
+                                                       ->displayValue( level / 100 );
                                y = yCoordOfLevel( level );
                                p.setPen( QApplication::palette().color( QPalette::Active,
                                                        QPalette::Shadow ) );

[StCyr]

Here's the corresponding PR: #2614

[Umcaruje]

Bumping to 1.3 as this is not a newly introduced bug and has been around for some time.

[zonkmachine]

Closed in #5661