Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glitchy interference with dummy instruments #2682

Closed
zonkmachine opened this issue Mar 18, 2016 · 0 comments
Closed

Glitchy interference with dummy instruments #2682

zonkmachine opened this issue Mar 18, 2016 · 0 comments

Comments

@zonkmachine
Copy link
Member

If an instrument fails to load lmms will load a dummy instrument that has no sound.
Since around commit 857de8d the dummy plugin has decided to join in when it can...

zonkmachine@zonkmachine:~/builds/lmms/lmms$ git bisect good
There are only 'skip'ped commits left to test.
The first bad commit could be any of:
9fe55161a83defb76d33ea751a03103362fbb607
68b5a21d14352188175b4f95f9041cbaa45b837e
dc4bfdc60defdd9b47a21848af70fd350ca7ef28
7bc97f5d5bd9fcb43971f62e546ba464be1e818f
f25da35c244be9fe3af3d4c73b44658bcecb10ae
50bfed7180b2554d80f7109c2a52b3f9a7a936ee
9a3d3cb3064e38c22b60d092a32edef1959673b9
1864dcfaa1260e2659c85d1fb63cb2d428e9f1ab
8a596b0898bdc12568c8b3670b52ba93bdb93e4e
1deb80acc38c4f42a5d7859a8251a9b09caed65a
f207613d5f98c4f657a3c21d8ac79872a8ffa071
857de8d2c829dc688745f41ba8eddbe148a63a20    <--- First
b441bdae15446f1965e38ef26a81cdad9c8da61a
ba05b7523d4fe1e757b74df7c8c12e3e532a09a7
We cannot bisect more!

Test project with a non existing instrument plugin
dummyPlugginGlitch.mmp.zip
grejppi added a commit that referenced this issue Mar 18, 2016
@grejppi
Merge pull request #2684 from grejppi/dummyinstrument
0021e31 
Clear buffer of dummy instruments. Should fix #2682
sambler added a commit to sambler/lmms that referenced this issue Sep 19, 2016
@sambler
Merge branch 'master' into jackmidi
9cda70c 
* master: (90 commits)
  Grey out muted patterns in the BB editor
  Crash at clearing path in settings manager
  Clear buffer of dummy instruments. Should fix LMMS#2682
  Get rid of another copy constructor call to prevent Qt5 crashes
  Enables style sheets for knob line colors for all knob types
  Kicker 'version' 0 on first save
  Add C++11 compile flag to the carla plugin as well
  Elide channel names to prevent text overflow in FxLine
  Replace every use of the foreach macro with a C++11 range-based for loop
  Compile several plugins with -std=c++0x to support range-based for loops
  Make lb302 include math.h so we can switch it to C++11
  File browser, factory files off by one
  Fix regression caused by fcec8dd
  Fix BBtrack updating; Fix the Pattern tooltip
  Rewrote ProjectVersionTest.cpp to use QVERIFY and indeed fail when it's supposed to fail, and added 2 tests in this test suite.
  data/locale: zh_CN.ts not zh.ts
  White-space formatting
  Add gig player to win32 builds
  Update Chinese translations
  Fix locale generation for win32 builds Closes LMMS#2577
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zonkmachine