Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sfxr - buffer noise #3383

Closed
zonkmachine opened this issue Feb 24, 2017 · 4 comments
Closed

sfxr - buffer noise #3383

zonkmachine opened this issue Feb 24, 2017 · 4 comments
Labels
bug

Comments

@zonkmachine
Copy link
Member

The usual buffer stuff. There is noise with other instruments with the decay if using the general envelope (ENV/LFO).

Example. May get a bit loud...
sfxrbuffer.mmp.zip
@PaulBatchelor
Copy link
Contributor

When you mute bitinvader after hitting play, you get a buzz, so something is getting "stuck" in the buffer.

@zonkmachine
Copy link
Member Author

I don't get any buzz with bitinvader (or sfxr) when muting on/off. With or without envelope and/or other instruments around.

@PhysSong
Copy link
Member

PhysSong commented Sep 3, 2017

If the R value for sfxr is large, you will get a buzz regardless of its settings. Can be reproduced without B&B.

@PhysSong PhysSong mentioned this issue Oct 15, 2017
Merged
@zonkmachine
Copy link
Member Author

If the R value for sfxr is large, you will get a buzz regardless of its settings

Yes, I seem to have mistaken. It's not in relation to other instruments. At least I can't reproduce that.

lukas-w added a commit that referenced this issue Oct 17, 2017
@lukas-w
PlayHandle: Zero out buffer before processing
6fc4577 
Fixes buffer noises when instruments don't write the whole buffer, such as
bitinvader. Related:
* #3884 (comment): #3884 (comment)
* #3883
# #3383
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
@lukas-w
PlayHandle: Zero out buffer before processing
05c2c53 
Fixes buffer noises when instruments don't write the whole buffer, such as
bitinvader. Related:
* LMMS#3884 (comment): LMMS#3884 (comment)
* LMMS#3883
# LMMS#3383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zonkmachine @PaulBatchelor @PhysSong