-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern names difficult to read #3674
Comments
A solution to that problem was proposed in this comment: At that time @musikBear preferred a mouse over as the solution. |
@michaelgregorius It is better with a shadowed box 👍 , but mouse-over-tooltip would still be a good addition, also because the current 'message' is self-explanatory, i believe its something most would do intuitively. Right-click also opens context options. |
@RebeccaDeField You are 100% on target !
( Later a search method for a named block, (drop-down) would be super) |
In my experience with text contrast white text with a black stoke does the trick 99.9% of the time. That said, @michaelgregorius, the proposal looks very nice. |
why don't we just reserve some space in the pattern where the text will go, and just change the note drawing routine to draw underneath that space? |
@Umcaruje This would be another option which would look similar to @RebeccaDeField first example (which I think is FL Studio). However, for that to work we'd really have to increase the default height of tracks because otherwise you'd see almost nothing of the notes (see my first screenshot). This in turn would imply that we need to fix the rendering of the beats and basslines patterns at increased heights. So the proposed option is the simplest for now. On a side note: it might be a good idea to make the resize option for the tracks a bit more obvious, e.g. by changing the cursor at the bottom of tracks to an up/down arrow which can be used to change the height of the track. Currently this functionality is very hidden. On the other hand I have just noticed that the changed track heights are not saved anyway. |
Not to mention that the elements don't center themselves when the track height is changed. It's a pretty broken feature
Oh and also my proposal would look very similar to the 2nd option, which is Bitwig 🙂 |
The Bitwig and FL screenshots are essentially the same concepts, only FL uses a lighter gradient in the same space set aside for the text. I think both of those proposals would need to have the default height of tracks increased to really work.
If we are looking for a temporary solution, I might decrease the height of the overlay and text to make it more compact. |
I think that in order to be flexible with vertical real estate it should be
possible to show/hide names, or maybe even show above/show inside/hide.
The first system that comes to my mind would be a global setting somewhere
(Song Editor toolbar?) with individual track overrides and the ability to
show/hide one single pattern name with hover.
On Jul 3, 2017 05:11, "Rebecca DeField" <notifications@github.com> wrote:
The Bitwig and FL screenshots are essentially the same concepts, only FL
uses a lighter gradient in the same space set aside for the text. I think
both of those proposals would need to have the default height of tracks
increased to really work.
So the proposed option is the simplest for now.
If we are looking for a temporary solution, I might decrease the height of
the overlay and text to make it more compact.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3674 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIgVmlwSaG_aY_Hows-RhMj-taT9g-IOks5sKE3fgaJpZM4OKmCL>
.
|
That would make it worse. The important thing is reading named tracks. For hide resp show, i would actually think that it would be better to hide the notes and not the names |
@musikBear To clarify, I was talking about making @michaelgregorius's proposed overlay slightly more compact because even FL uses a smaller font and we have to be mindful of real-estate. The font could be bigger than what we have now, but let's not go too far. 👍 |
I really don't like adding more configuration options to the software, especially something so trivial. If people don't want names on the patterns, they shouldn't name the patterns.
I agree. The name of the segment is often more important than the thumbnail of it. The proposed text size looks reasonable and sane.
This is a good point. The more text we can fit in small segments the more useful. @michaelgregorius can you do a mockup with a slightly smaller font? :) |
@michaelgregorius I agree with you. I would be curious to know what size we are currently using. You could probably also get away with increasing the alpha value in the overlay to 75 for a bit more contrast. 👍 |
Me, the sight impaired 'bat' i am, can only read the Point size 7, but a css option would completely shut me up :) |
@musikBear Yes, a 6pt font is pretty small. I would think that is the very minimum. Knowing what size we are using now would give us a much better idea on which size to choose. :) |
@RebeccaDeField The current size is 8 points if that makes the decision easier. :) It's also the size that's shown in the first experimental screenshots from two days ago. Currently the font size of the pattern is bigger than the size used to display the instrument's name which seems a bit off to me anyway. |
@RebeccaDeField Here's how it looks with a background of RGBA(0, 0, 0, 75) by the way: The notes are still distinguishable from the text so I'd say we get away with this. :) |
@michaelgregorius I like the wide one 👍 |
From what I can tell, changing the font size of the pattern to 7 will also match the instrument name size. |
Looking at picture from comment #3674 (comment) |
I have now changed it so that the font properties are taken from the style sheets. The font sizes of the instrument names are defined in pixels (11px) therefore I have set the font size for the patterns to 11px as well. Both style sheets (classic and default) have been adjusted. The pull request is #3691. |
Closed via #3691. |
Difference between notes and letters are not sufficient, if they overlap -Maby more dark in the letters? (mouse over tooltips still shows 'open in piano-roll')
The text was updated successfully, but these errors were encountered: