Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected notes in the Piano Roll editor do not look much different from unselected notes #4111

Closed
raindropsfromsky opened this issue Jan 15, 2018 · 9 comments
Assignees
Labels
Milestone

Comments

@raindropsfromsky
Copy link

Earlier, the selected bars in the Piano Roll Editor appeared deep blue, and the unselected bars appeared green. Thus they looked distinct from each other, and it was easy to tell them apart.

image

But now the selected bars have a different hue of green. As a result, it is very difficult to tell which bars are selected and which are not.
image

Desired: Retain the color difference so that the user can easily tell which bars are selected.
In fact, showing the selected bars in yellow would be a good choice.

@Spekular
Copy link
Member

Spekular commented Jan 15, 2018 via email

@tresf
Copy link
Member

tresf commented Jan 15, 2018

@raindropsfromsky thanks for this, we'll put it on the to-do list for 1.2.0. @Umcaruje let's make the contrast better here. @Spekular thanks for the research.

@tresf tresf added the bug label Jan 15, 2018
@tresf tresf added this to the 1.2.0 milestone Jan 15, 2018
@husamalhomsi husamalhomsi changed the title The selected bars in the Piano Roll Editor do not look much different from unselected bars Selected notes in the Piano Roll editor do not look much different from unselected notes Jan 15, 2018
@raindropsfromsky
Copy link
Author

About the color: Blender 3D uses orange outline to indicate that a shape is selected.
image
In the scene, the cylinder is selected, and the cube is not.

@musikBear
Copy link

musikBear commented Jan 15, 2018

It is available as a CSS option. My lousy eyes have already prompted me to change both selections and how scales are shown.
pianoroll_cssmb

@raindropsfromsky Here is my file:
Copy (4) of style.zip
Substitute it with the one you have in
:\data\themes\default
rename it style.css

@lukas-w
Copy link
Member

lukas-w commented Jan 15, 2018

"In males with protanopia, there are no working red cone cells. Red appears as black. Certain shades of orange, yellow, and green all appear as yellow."

In case we want to take this into account without guess-working about what would look right, there's software like Color Oracle that applies a full-screen filter to simulate colour blindness.

@tresf
Copy link
Member

tresf commented Jan 15, 2018

This ColorOracle utility is very nice. You don't need to install it either, you can just grab the JAR, which will open if you have Java installed already.

http://colororacle.org/ColorOracleJar.zip

Double-click the jar and then right-click the tray icon and select a color-blind profile it will temporarily switch a snapshot of your desktop to that color profile.

Interestingly enough, the selected notes actually appear to be grayed-out with the most common color blindness, but they actually appear a bit easier to differentiate, so this may be less of a color-blindness problem and more of a general contrast problem.

Common
image

Rare
image

Very Rare
image

@musikBear
Copy link

It is even simpler here
http://www.color-blindness.com/coblis-color-blindness-simulator/
Just drop any picture
My suggestion is no good either.
Users with Blue-Weak/Tritanomaly wont see any difference at all

Discuss:
Wouldent this perhaps best be tackled with a set of CSS files?
I doubt it will be possible to retain a nice design, where all kind of color- impaired would see sufficient differences, and at the same time have a design that is pleasant for those with normal eyes.

@raindropsfromsky
Copy link
Author

raindropsfromsky commented Jan 16, 2018 via email

@tresf
Copy link
Member

tresf commented Feb 28, 2018

Another trick to force strict black/white on Windows is Ctrl + Meta(Win) + C, pardon the beep this makes.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants