Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation in Swedish displays % character in menu #4415

Closed
saurid opened this issue Jun 9, 2018 · 14 comments
Closed

Translation in Swedish displays % character in menu #4415

saurid opened this issue Jun 9, 2018 · 14 comments

Comments

@saurid
Copy link

saurid commented Jun 9, 2018

Menu option "View" in swedish shows "%Visa" instead of the correct "Visa". Windows 10 version 1.2.0-rc6
image

@PhysSong
Copy link
Member

PhysSong commented Jun 9, 2018

I guess it should be &Visa. Ampersands are used for accelerator keys.

@saurid
Copy link
Author

saurid commented Jun 9, 2018

Seems like it, yes. Alt-V is not working for this menu option, but does work for the other ones.

@zonkmachine
Copy link
Member

I suggested a fix for this on Transifex but couldn't push it as I don't seem to be cool enough to do this. I just glanced over the Swedish translation and it looks like people have been pushing changes online without testing it against lmms.

@PhysSong
Copy link
Member

For 1.2, it'd be sufficient to edit sv.ts.

@zonkmachine
Copy link
Member

Translations won't be merged back from transifex before 1.2?

@Spekular
Copy link
Member

Spekular commented Jun 10, 2018

I fixed it on transifex FWIW. Couldn't seem to select zonk's translation so it's credited to me now? I don't entirely get transifex.

@zonkmachine
Copy link
Member

OK. I resolved the Transifex issue.

@SecondFlight
Copy link
Member

Can this be closed then?

@zonkmachine
Copy link
Member

I'd like to know how changes are merged back to 1.2 first. I'm a total noob at Transifex.

@PhysSong
Copy link
Member

Editing this part should work:

lmms/data/locale/sv.ts

Lines 3941 to 3942 in 2f19fa1

<source>&amp;View</source>
<translation>%Visa</translation>

Though not directly related, I also found one place where accelerator is missing:

lmms/data/locale/sv.ts

Lines 306 to 307 in 2f19fa1

<source>&amp;Copy value (%1%2)</source>
<translation>Kopiera värde (%1%2)</translation>

@zonkmachine
Copy link
Member

Yes, but isn't the translations going to be merged back from Transifex?

@PhysSong
Copy link
Member

IIRC Transifex is synced with master now. @liushuyu Is it correct?

@Spekular
Copy link
Member

Spekular commented Jun 17, 2018

Updated the "Copy Value" translation to "&Kopiera värde (%1%2)" on Transifex as well. I was unsure about that earlier since it changes the accelerator key, but I guess it's better than not having one at all.

@PhysSong
Copy link
Member

i18n strings in stable-1.2 have never been updated since 9 May 2017 so I fixed it manually in 1bae047.

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants