Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abbreviate effect module decay knob label #5750

Closed
sound8 opened this issue Oct 29, 2020 · 2 comments · Fixed by #5766
Closed

Abbreviate effect module decay knob label #5750

sound8 opened this issue Oct 29, 2020 · 2 comments · Fixed by #5766
Labels
enhancement

Comments

@sound8
Copy link

sound8 commented Oct 29, 2020

Effect modules have three knobs
W/D, DECAY, GATE

The "DECAY" label kind of runs into the GATE label, to me it just doesn't look right.
Maybe consider abbreviating the "DECAY" label to "DEC" so the labels are not so close together.

Obviously not a big deal but would clean up the look of things.
@Spekular
Copy link
Member

The real issue is that the space between decay and gate is shorter than the space between W/D and decay. If this were fixed the labels would be fine as is.
image

Measuring pixels in that screenshot, the first margin is 9 pixels and the second is 3.

@sound8
Copy link
Author

sound8 commented Oct 31, 2020 •
edited
Loading

If you are referring to the spacing between the knobs then I would agree.
The only reason I didn't mention this is because I figured I would have a better chance of someone abbreviating a text label over moving a knob and label a little to the right.
So yeah, two ways to fix this.
1.) Abbreviate "DECAY" label to "DEC"
2.) Move Gate knobw and "GATE" label over to the right.

@sound8 sound8 mentioned this issue Oct 31, 2020
Closed
DigArtRoks added a commit to DigArtRoks/lmms that referenced this issue Nov 4, 2020
@DigArtRoks
Fix EffectRackView appearance (GUI).
9dd8c83 
* Elide the name of the effect when it tends to be too big. (LMMS#5752)
* Evenly space the controls (W/D, Decay Gate). (LMMS#5750)
* Show the scrollbar in the default theme to close the gap. (LMMS#5752)
* Reduce the gap between the effect and the scrollbar. (LMMS#5757)
* Use always the same width for the EffectRackview (InstrumentTrack and SampleTrack) to avoid gaps or cutoffs of the background.
* Widen the background in the default theme.
* Widen the embossed space in the background in the classic theme to fit the controls.
@DigArtRoks DigArtRoks mentioned this issue Nov 4, 2020
Merged
@DomClark DomClark linked a pull request Nov 4, 2020 that will close this issue
Fix EffectRackView appearance (GUI). #5766
Merged
Spekular pushed a commit that referenced this issue Nov 7, 2020
@DigArtRoks
Fix EffectRackView appearance (GUI). (#5766)
a6e3958 
* Fix EffectRackView appearance (GUI).

* Elide the name of the effect when it tends to be too big. (#5752)
* Evenly space the controls (W/D, Decay Gate). (#5750)
* Show the scrollbar in the default theme to close the gap. (#5752)
* Reduce the gap between the effect and the scrollbar. (#5757)
* Use always the same width for the EffectRackview (InstrumentTrack and SampleTrack) to avoid gaps or cutoffs of the background.
* Widen the background in the default theme.
* Widen the embossed space in the background in the classic theme to fit the controls.

* Changes for improving the EffectRackView after reviews.

* Reduce the background for the default theme by 1 pixel.
* Reduce the background for the classic theme by 2 pixels and remove the darker line at the bottom right.
* Reduce the width of long names of the plugin also by 2 pixels.
* Put the controls 2 pixels closer to each other.
IanCaio pushed a commit to IanCaio/lmms that referenced this issue Mar 28, 2021
@DigArtRoks @IanCaio
Fix EffectRackView appearance (GUI). (LMMS#5766)
176fff3 
* Fix EffectRackView appearance (GUI).

* Elide the name of the effect when it tends to be too big. (LMMS#5752)
* Evenly space the controls (W/D, Decay Gate). (LMMS#5750)
* Show the scrollbar in the default theme to close the gap. (LMMS#5752)
* Reduce the gap between the effect and the scrollbar. (LMMS#5757)
* Use always the same width for the EffectRackview (InstrumentTrack and SampleTrack) to avoid gaps or cutoffs of the background.
* Widen the background in the default theme.
* Widen the embossed space in the background in the classic theme to fit the controls.

* Changes for improving the EffectRackView after reviews.

* Reduce the background for the default theme by 1 pixel.
* Reduce the background for the classic theme by 2 pixels and remove the darker line at the bottom right.
* Reduce the width of long names of the plugin also by 2 pixels.
* Put the controls 2 pixels closer to each other.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
@DigArtRoks
Fix EffectRackView appearance (GUI). (LMMS#5766)
744b7d4 
* Fix EffectRackView appearance (GUI).

* Elide the name of the effect when it tends to be too big. (LMMS#5752)
* Evenly space the controls (W/D, Decay Gate). (LMMS#5750)
* Show the scrollbar in the default theme to close the gap. (LMMS#5752)
* Reduce the gap between the effect and the scrollbar. (LMMS#5757)
* Use always the same width for the EffectRackview (InstrumentTrack and SampleTrack) to avoid gaps or cutoffs of the background.
* Widen the background in the default theme.
* Widen the embossed space in the background in the classic theme to fit the controls.

* Changes for improving the EffectRackView after reviews.

* Reduce the background for the default theme by 1 pixel.
* Reduce the background for the classic theme by 2 pixels and remove the darker line at the bottom right.
* Reduce the width of long names of the plugin also by 2 pixels.
* Put the controls 2 pixels closer to each other.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix EffectRackView appearance (GUI). DigArtRoks/lmms
2 participants
@Spekular @sound8