#6725 breaks Unfa-Spoken and possibly other projects #6828
Assignees
Labels
Comments
michaelgregorius
added a commit
to michaelgregorius/lmms
that referenced
this issue
Aug 27, 2023
Towards the end of the development for the fix of LMMS#6548 (via LMMS#6725) the upgrade code was refactored into its own class. While doing so it was forgotten to actually call the `upgrade` method on the `UpgradeExtendedNoteRange` instance. As a result almost all files should currently open in a wrong state with many instruments transposed. This commit fixes this. Also explicitly check the assertion that BB tracks do not contain other BB tracks.
michaelgregorius
added a commit
that referenced
this issue
Aug 27, 2023
…tionFix Fix the base note automation fix (#6828)
|
This is fixed with #6832. Builds from version 4ff9507 to fc2f6a0 did not actually call the upgrade code which adjusts the base notes and as a result most files should open with lots of transposed instruments. This was fixed with commit 0e93f13. Files that have been saved with the aforementioned versions should not be affected, i.e. projects that have been created with nightlies of these versions should not be affected by the fix and sound the same. |
|
@kamkamkamkamkamkamkamkam, can you please check with a nightly that contains the fix? |
|
unfa-Spoken now sounds perfectly normal 👍 |
|
Thanks for testing @kamkamkamkamkamkamkamkam! I will close this issue then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Summary
#6725 breaks Unfa-Spoken and possibly other projects
Steps to reproduce
load Unfa-Spoken in latest nightly
Expected behavior
normal playback
Actual behavior
multiple elements are pitched up by an octave, because of the base pitch being modified
Screenshot
Affected LMMS versions
Nightly
The text was updated successfully, but these errors were encountered: