Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZynAddSubFX, 2 possible bugs ? #759

Closed
mikobuntu opened this issue May 22, 2014 · 14 comments
Closed

ZynAddSubFX, 2 possible bugs ? #759

mikobuntu opened this issue May 22, 2014 · 14 comments
Labels
Milestone

Comments

@mikobuntu
Copy link
Contributor

Hi I am currently using LMMS master branch right up to date as of today. Im running on ubuntu 12.04 32bit. I have noticed any sliders in the actual Zasf GUI will get pixelated/trapped whenever moved. And also i see a lag in loading time where zasf used to load within milliseconds... can anyone else confim ?

  • note cpu hits 100% and LMMS gui freezes until zasf is loaded fully*
    screenshot from 2014-05-22 22 05 04

see where my mouse pointer is hovering...

thanks Mikobuntu

@softrabbit
Copy link
Member

64 bit Ubuntu 12.04, and I can confirm that slider problem in master. And the "Instrument Edit" window seems to get its background from some random window in the system, see upper right-hand corner of screenshot above. I had some xterm text in it...

Neither of these happen in a stand-alone Zynaddsubfx compiled from its master branch.

@diizy diizy added the bug label Jun 8, 2014
@diizy diizy added this to the 1.1.0 milestone Jun 8, 2014
@diizy
Copy link
Contributor

diizy commented Jun 8, 2014

Marking this for 1.1 as it's something that should be solved before release.

@tresf
Copy link
Member

tresf commented Jun 23, 2014

I got the visual artifacts to go away by reverting this line to that of the old Zyn code.

BEFORE

xywh {247 621 395 360} type Double box NO_BOX visible

AFTER

xywh {182 214 395 360} type Double hide

Not entirely sure how or why. Instinct is a problem with the constructor that the hide function fixes, but this seems like it would be a problem upstream too.

-Tres

@tresf
Copy link
Member

tresf commented Jun 28, 2014

Possibly unrelated but the behavior is now the same as #703 (Apple) where audio works fine but the GUI won't load at all.

@tresf
Copy link
Member

tresf commented Jul 2, 2014

Zasf GUI will get pixelated/trapped whenever moved

Zasf GUI slider artifacts

Zasf lag in load time

  • In regards to Zasf lag in load time, I don't have a native Linux install to test performance out on so hopefully someone else can confirm that report.

A side note, these should probably be three two separate bug reports but I'll do my best to track them all here.

Another side note... to follow up with my previous comment on the possible relation of these issues to the Win32 crashes, the bugs are not related but FYI - Win32 has been fixed with pull request #919.

@mikobuntu
Copy link
Contributor Author

I can now confirm that i no longer have the lag in ZASF loading time, it could possibly been due to building in a non clean environment or such, but after doing a new/clean install i no longer have the problem, so this part can be closed... and indeed i should have done these as separate bugs ooops :0

thanks Mikobuntu ;)

Zasf lag in load time

In regards to Zasf lag in load time, I don't have a native Linux install to test performance out on so hopefully someone else can confirm that report.
A side note, these should probably be 3 separate bug reports but I'll do my best to track them all here.

Another side note... to follow up with my previous comment on the possible relation of these issues to the Win32 crashes, they're not but Win32 has been fixed with pull request #919.


Reply to this email directly or view it on GitHub.

@tresf
Copy link
Member

tresf commented Jul 2, 2014

Ok, I have some more information on the GUI artifacts. It appears to be new(er) behavior of FLTK and I created by "NO BOX" and I was able to find some information on the mailing list about this.

Instead of linking the original article, I'm linking the post to the KVR dev team which may be able to fix this upstream.

http://www.kvraudio.com/forum/viewtopic.php?f=47&t=415142

@tresf
Copy link
Member

tresf commented Jul 2, 2014

Got it.

cd ~/lmms/plugins/zynaddsubfx/zynaddsubfx/src/UI
sed -i 's/NO_BOX/FLAT_BOX/g' *.fl

Will submit pull request for now and request these changes are pushed upstream.

@diizy
Copy link
Contributor

diizy commented Jul 2, 2014

On 07/02/2014 09:38 PM, Tres Finocchiaro wrote:

Got it.

cd ~/lmms/plugins/zynaddsubfx/zynaddsubfx/src/UI
sed -i 's/NO_BOX/FLAT_BOX/g' *.fl

Will submit pull request for now and request these changes are pushed
upstream.

Remember, the pull request should be filed in the lmms/zynadsubbfx repo

@tresf
Copy link
Member

tresf commented Jul 2, 2014

Good catch. Pull request sent. Also reverted your change.

LMMS/zynaddsubfx#2

@diizy
Copy link
Contributor

diizy commented Jul 2, 2014

On 07/02/2014 10:02 PM, Tres Finocchiaro wrote:

Good catch. Pull request sent. Also reverted your change.

LMMS/zynaddsubfx#2 LMMS/zynaddsubfx#2

Tres, maybe you should revert the coordinates too? I'm sure they were
changed for a reason...

@tresf
Copy link
Member

tresf commented Jul 2, 2014

revert the coordinates

Yes, that was my intention but I missed it thank you. Committed. LMMS/zynaddsubfx#2

@tresf
Copy link
Member

tresf commented Jul 2, 2014

Here are the updated Windows installers which address the #892 "show voice parameters" Zyn crash on Windows XP as well as the #759 "visual artifacts" bugs.

I intentionally and prematurely bumped the version of these installers to 1.0.92 as to easily distinguish from the previous versions.

32-bit

(link removed)

64-bit

(link removed)

@diizy
Copy link
Contributor

diizy commented Jul 3, 2014

These should be fixed in latest stable-1.1 now so I'm closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants