Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed fix 1502 incorrect slash in windows #1609

Merged
merged 1 commit into from
Jan 12, 2015
Merged

proposed fix 1502 incorrect slash in windows #1609

merged 1 commit into from
Jan 12, 2015

Conversation

curlymorphic
Copy link
Contributor

proposed fix for issue #1502 Wrong slash in windows

This fix simply uses Qt's QDir::toNativeSeparators for the display values in the settings dialog.
The stored file paths remain untouched, I feel this is safest, from what i have read Qt automatically converts when accessing files.

@Sti2nd @StakeoutPunch @Umcaruje or @SecondFlight

Can you please test this on windows?

@Umcaruje
Copy link
Member

I'll make a build for testing this :)

@curlymorphic
Copy link
Contributor Author

@Umcaruje thanks

@tresf
Copy link
Member

tresf commented Jan 12, 2015

@curlymorphic very elegant! Thanks! @Umcaruje thanks as well.

@Umcaruje
Copy link
Member

Here is a win64 version: https://drive.google.com/file/d/0B49dcRGtm8vJZk1QVXZlQjFNblE/view?usp=sharing

Will install and test in a moment.

@tresf
Copy link
Member

tresf commented Jan 12, 2015

Looking pretty good... that extra slash on STK is erroneous but probably exists elsewhere in the code (or leftover from the old config)

image

@Umcaruje
Copy link
Member

Yup, fixed :
fdfsaasfdafsd

lukas-w added a commit that referenced this pull request Jan 12, 2015
proposed fix 1502 incorrect slash in windows
@lukas-w lukas-w merged commit 854f1d1 into LMMS:master Jan 12, 2015
@tresf tresf mentioned this pull request Jan 12, 2015
@badosu
Copy link
Contributor

badosu commented Jan 13, 2015

@curlymorphic Good one! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants