-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the man page and the windows installer info #2124
Conversation
Looks fine to me. I wonder if we can extract the version info dynamically from the git tags to prevent that from getting outdated again. |
@@ -63,7 +63,7 @@ Show version information and exit. | |||
.IP "\fB\-h, --help | |||
Show usage information and exit. | |||
.SH SEE ALSO | |||
.BR http://lmms.sf.net/ | |||
.BR http://lmms.sf.net/wiki/ | |||
.BR http://lmms.io/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*https
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it 👍
|
Actually, the proper sytax is used lower in the file, just copy that I think the idea here is that the |
I don't know enough about this file to tell if this is important or not, but changing it from To retain the current format, but having it update dynamically, the proper fix would look something like These macros are defined in CMakeLists:16-18. |
Also, this file does indeed get variable substitution. See CMakeLists:371. |
Agreed. 👍 |
Updated the fileversion line to |
👍 |
The travis build passed, is there anything holding this from being merged? |
Ok, fair enough. Merging. |
Update the man page and the windows installer info
The site info and version info was outdated.