Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes an unused knob and enum (knob04.png aka knobGreen_17) #2644

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

michaelgregorius
Copy link
Contributor

Removes the knob image knob04.png. This knob corresponded to the enum value
knobGreen_17 which was not used anywhere in the code. To be able to
remove the enum value it was necessary to change the knob loading code
in Knob::onKnobNumUpdated. However, the changed implementation is more
explicit and therefore likely better to understand.

Removes the knob image knob04.png. This knob corresponded to
knobGreen_17 which was not used anywhere in the code. To be able to
remove the enum value it was necessary to change the knob loading code
in Knob::onKnobNumUpdated. However, the changed implementation is more
explicit and therefore likely better to understand.
@michaelgregorius
Copy link
Contributor Author

With the more explicit mapping of enums to file names in Knob::onKnobNumUpdated we should also consider to rename the knob images to something more explicit, e.g. name the images like the enums.

@Wallacoloo
Copy link
Member

👍 looks fine to me.

michaelgregorius added a commit that referenced this pull request Mar 15, 2016
Removes an unused knob and enum (knob04.png aka knobGreen_17)
@michaelgregorius michaelgregorius merged commit 5d3333b into LMMS:master Mar 15, 2016
@michaelgregorius michaelgregorius deleted the knob-enum-cleanup branch March 15, 2016 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants