Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides a new GUI for the peak controller plugin #2816

Merged
merged 2 commits into from
Jun 9, 2016

Conversation

BaraMGB
Copy link
Contributor

@BaraMGB BaraMGB commented Jun 2, 2016

bildschirmfoto von 2016-06-02 16-49-09

I wait for an answer from @RebeccaDeField for providing a better artwork.png for this.

The label of the amount knob is different to the label of the LFO controller. In Peak controller it is "AMNT" named. In LFO controller "AMT". I suggest, we should decide for one version. I think, "AMNT" is the better choice, but for that, I have to make an other PR to change the LFO. If we decide for "AMT", I can do this with this PR.

Regards

@RebeccaDeField
Copy link
Contributor

RebeccaDeField commented Jun 3, 2016

I inspected both the LFO and Peak controllers and came to the conclusion that the LFO title had too much anti-aliasing and the Peak had a bit too little (notice how the L's are flush together. Sub-pexel rending would probably be the perfect solution, but unfortunately, to my knowledge Inkscape does not currently have that capability.

I played around with the kerning, hinting, tracking, different font sizes, etc and came to something that I think is a good compromise between the two.
lfo2
peakcontroller

I also realized that the LFO and Envelope graph would need to match, but the smaller font size caused some issues. I found that choosing a lighter font weight and making a couple of tweaks in the GIMP has the best results.

lfo
envelope

Please note that the last two are transparent, so they won't look the same here as they will in the program. I'll take care of the PR for those two with with the waveform selectors.

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Jun 3, 2016

Thank you very much, @RebeccaDeField. I set the new artwork in, soon. For the lfo controller I make a new PR.

@Umcaruje any suggestions?

@Umcaruje
Copy link
Member

Umcaruje commented Jun 3, 2016

Sub-pexel rending would probably be the perfect solution, but unfortunately, to my knowledge Inkscape does not currently have that capability.

By rendering with Cairo PNG, you get better font hinting in inkscape: http://libregraphicsworld.org/blog/entry/getting-crisper-text-out-of-inkscape

I'm not sure its exactly sub-pixel rendering, but it really saves you the trouble of going to gimp and manually editing the text. You also ought to know that Cairo PNG doesn't support transparency, so for that you'll need to manually convert the black color to alpha, by using the Gimp 'color to alpha' tool.

The Cairo PNG export is located in the Save As…/Save Copy As… dialog.

@Umcaruje any suggestions?

You could easily replace the lfo controller artwork too, just make a seperate commit.

Also @BaraMGB @RebeccaDeField this shuld also happen with the amplifier plugin and others, so it'd be nice to share the final .svg with the "winning formula"

@BaraMGB BaraMGB force-pushed the PeakControllerGUI branch from e70577f to 4617bfa Compare June 3, 2016 12:29
@BaraMGB
Copy link
Contributor Author

BaraMGB commented Jun 3, 2016

Okay, done so far. And changed the amount knob label in LFO.

bildschirmfoto von 2016-06-03 14-24-26

@RebeccaDeField
Copy link
Contributor

RebeccaDeField commented Jun 3, 2016

By rendering with Cairo PNG, you get better font hinting in inkscape

Cairo PNG actually is what I use for hinting 👍 It just took some tweaks to the SVG before exporting to get it to look right. For example, if you bring the font 1px down in size it doesn't work all that well.

I'm not sure its exactly sub-pixel rendering, but it really saves you the trouble of going to gimp and manually editing the text.

Yes, I don't think it supports sub-pixel rendering, but it still is a pretty good hinting tool. That is why I had to make a couple of edits in the GIMP on the Cairo exports that were using the light weight font (I couldn't use bold on the smaller ones without it looking muddy.)

I didn't make any edits in GIMP on the first two with the bold font after exporting in Cairo.

It'd be nice to share the final .svg with the "winning formula"

I'll update the SVG's in my pull request when I get a chance.

@Umcaruje
Copy link
Member

Umcaruje commented Jun 9, 2016

@BaraMGB are there gonna be any updates to the artworks or is this the final version, and we can merge?

@BaraMGB
Copy link
Contributor Author

BaraMGB commented Jun 9, 2016

If you don't have objections about this, it can be merged.

@Umcaruje Umcaruje merged commit 9eec9a0 into LMMS:master Jun 9, 2016
@Umcaruje
Copy link
Member

Umcaruje commented Jun 9, 2016

👍

@BaraMGB BaraMGB deleted the PeakControllerGUI branch June 20, 2016 11:48
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
provides a new GUI for the peak controller plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants