-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provides a new GUI for the peak controller plugin #2816
Conversation
Thank you very much, @RebeccaDeField. I set the new artwork in, soon. For the lfo controller I make a new PR. @Umcaruje any suggestions? |
By rendering with Cairo PNG, you get better font hinting in inkscape: http://libregraphicsworld.org/blog/entry/getting-crisper-text-out-of-inkscape I'm not sure its exactly sub-pixel rendering, but it really saves you the trouble of going to gimp and manually editing the text. You also ought to know that Cairo PNG doesn't support transparency, so for that you'll need to manually convert the black color to alpha, by using the Gimp 'color to alpha' tool. The Cairo PNG export is located in the Save As…/Save Copy As… dialog.
You could easily replace the lfo controller artwork too, just make a seperate commit. Also @BaraMGB @RebeccaDeField this shuld also happen with the amplifier plugin and others, so it'd be nice to share the final .svg with the "winning formula" |
e70577f
to
4617bfa
Compare
Cairo PNG actually is what I use for hinting 👍 It just took some tweaks to the SVG before exporting to get it to look right. For example, if you bring the font 1px down in size it doesn't work all that well.
Yes, I don't think it supports sub-pixel rendering, but it still is a pretty good hinting tool. That is why I had to make a couple of edits in the GIMP on the Cairo exports that were using the light weight font (I couldn't use bold on the smaller ones without it looking muddy.) I didn't make any edits in GIMP on the first two with the bold font after exporting in Cairo.
I'll update the SVG's in my pull request when I get a chance. |
@BaraMGB are there gonna be any updates to the artworks or is this the final version, and we can merge? |
If you don't have objections about this, it can be merged. |
👍 |
provides a new GUI for the peak controller plugin
I wait for an answer from @RebeccaDeField for providing a better artwork.png for this.
The label of the amount knob is different to the label of the LFO controller. In Peak controller it is "AMNT" named. In LFO controller "AMT". I suggest, we should decide for one version. I think, "AMNT" is the better choice, but for that, I have to make an other PR to change the LFO. If we decide for "AMT", I can do this with this PR.
Regards