Redesign of the Controller Rack #2944

BaraMGB · 2016-07-28T11:38:34Z

Peak controller and LFO controller will be inserted directly in the controller Rack. So we can avoid a lot of floating windows. In my opinion the rack makes more sense in this way.

Umcaruje · 2016-07-28T12:25:02Z

src/gui/widgets/ControllerView.cpp

+	int titleBarHeight = 24;
+	QPainter p( this );
+	QRect rect( 1, 1, width()-2, titleBarHeight + 5 );
+	QLinearGradient grad( QPoint( 0, 0 ), QPoint( 0, 24 ) );


This whole thing could be avoided if you just use the background property in css and define it in css. In the end you'd set the rectrangle fill to

p.fillRect( rect, painter.background() );

Umcaruje · 2016-07-28T12:51:18Z

I think the controllers should be centered in the window.

BaraMGB · 2016-07-28T13:41:06Z

I think the controllers should be centered in the window.

I try to change the width() of the window depending of needing a scrollbar or not.

BaraMGB · 2016-07-31T16:45:38Z

I updated this. The window width relates now on the need of a scrollbar.

BaraMGB · 2016-07-31T17:03:06Z

src/gui/widgets/EffectView.cpp

-					this, SLOT( closeEffects() ) );
-
-			m_subWindow->hide();
+			if( !(m_controlView->windowTitle() == "Peak Controller") )


I should find a more elegant way to identify the peak controller.

more elegant way to identify the peak controller

Research points to dynamic_cast against PeakController and checking for != NULL

BaraMGB · 2016-08-02T22:33:40Z

src/gui/widgets/EffectView.cpp

@@ -111,7 +112,7 @@ EffectView::EffectView( Effect * _model, QWidget * _parent ) :
 		m_controlView = effect()->controls()->createView();
 		if( m_controlView )
 		{
-			if( !(m_controlView->windowTitle() == "Peak Controller") )
+			if( dynamic_cast<PeakControllerEffectControlDialog*>( m_controlView ) == NULL )


I had to remove the Q_OBJECT macro from PeakControllerEffectDialog otherwise I get a linker error. Actually the Q_OBJECT macro isn't needed because there is no Signal/Slot stuff in this class. and everything works fine. But eventually someone can look into this.

BaraMGB · 2016-08-10T08:21:40Z

This one will be not ready before 1.2 is released. I'm targeting 1.3.

miketurn · 2017-01-13T16:38:54Z

@BaraMGB
Pretty cool, thank you for working on this.

#3235
Not sure if this will affect you but I figured I would mention it

BaraMGB · 2017-01-13T16:58:37Z

Yes, I made a PR for this : #3240

miketurn · 2017-01-16T23:24:59Z

@BaraMGB
I had a couple of ideas/questions to share (please ignore them if they are not helpful)
Some of these might be duplicates of above comments, don't understand coding.

1.) Currently you can change the names of the controllers, will you still be able to offer this?
2.) Would it be possible to be able to move items up and down? (Preferably through a mouse button drag method)
3.) At first I was going to ask if the expand/collapse arrows are necessary, but I guess it couldn't hurt to have them, they will probably would help in keeping the list clean.
4.) If these arrows do remain, would it be possible to add options to "expand all" and "collapse all"?
That might be helpful.

Again I have not used this feature much yet so you and others would be able to answer if these above questions are helpful or not.
Anyways, hope this helps. Thanks again for working on this.

karmux · 2019-08-25T14:46:51Z

@BaraMGB works perfectly now! 👍

BaraMGB · 2019-08-27T09:10:42Z

@PhysSong do you have time for a look at this?

src/gui/widgets/ControllerRackView.cpp

include/ControllerView.h

plugins/peak_controller_effect/CMakeLists.txt

src/gui/widgets/EffectView.cpp

PhysSong · 2019-08-29T00:21:10Z

I think you should export ControllerRackView class in order to make this work on Windows.

-class ControllerRackView : public QWidget, public SerializingObject
+class LMMS_EXPORT ControllerRackView : public QWidget, public SerializingObject

BaraMGB · 2019-08-29T12:08:12Z

I guess the main problem I have with this pull request is located in the PeakControllerDialog.cpp. I had to include:
#include "plugins/peak_controller_effect/peak_controller_effect_control_dialog.cpp"
I think to include a .cpp file is bad style. But I got a linker error if I include the .h instead.

Furthermore, I had to remove the Q_OBJECT macro from the PeakControllerEffectControlDialog class because I received further linker errors.

I don't know how to solve these problems. I would be very happy about help.

PhysSong · 2019-08-29T12:10:13Z

@BaraMGB I will try to help you this weekend.

tecknixia · 2019-10-14T22:50:08Z

Linux Mint 64

I had a lot of trouble setting this up, maybe because I don't know what I'm doing yet. I do have a working version on my computer now.

I cloned LMMS/lmms and rebased from this branch. Had trouble with cmake, and had to resolve conflicts during the rebase.

I had to add QWhatsThis and displayHelp() to ControllerView.h before Qt would compile it.

Also got a message when first compiling, something about no classes for
plugins/peak_controller_effect/peak_controller... something or other.

ghost · 2019-10-14T23:21:29Z

src/gui/PeakControllerDialog.cpp

+
+#include "EffectControlDialog.h"
+#include "plugins/peak_controller_effect/peak_controller_effect.h"
+#include "plugins/peak_controller_effect/peak_controller_effect_control_dialog.cpp"


Can't you include "embed.h" and <QIcon> and then change line 42 to:

setWindowIcon( QIcon(embed::getIconPixmap( "controller" )) );

instead of including peak_controller_effect_control_dialog.cpp?

I don't understand. Please, can you elaborate? Have you tested your suggestion?

Yes when I remove the .cpp include it fails compiling with: error: 'embed' has not been declared.

So I added #include "embed.h". Then it fails because setWindowIcon aspects a QIcon but a QPixmap is given.

So that's why also included <QIcon> and changed the setWindowIcon line.

After that it compiles and works fine here.

tecknixia · 2019-10-15T10:06:13Z

Also, not sure if I made a mistake when resolving conflicts... (I remember being unsure about one line of code) but I can confirm, as mentioned by @zonkmachine in #3240 that it's possible to make the Controller Rack window disappear by grabbing the bottom frame and moving up.

Edit ----

So I started experimenting a bit and came up with this line:
m_subWin->setMinimumSize(m_subWin->size());

To be placed after the last command in:
ControllerRackView::ControllerRackView()

BaraMGB · 2019-10-15T14:36:28Z

@tecknixia probably it's simpler to checkout the branch directly instead of trying to merge it into your master? To fix merge conflicts can be hard.

tecknixia · 2019-10-23T02:14:51Z

@BaraMGB oh... it's a branch... that makes sense 🤣 newbie mistake.

sound8 · 2020-10-31T21:02:49Z

Man, this looks great, does anyone know if this is still planned on being added to LMMS?

BaraMGB · 2020-11-01T13:53:33Z

I wrote this 4 years ago. This is really old code now and it would be complicated to understand what I made. If lmms want to have a single window interface, something like this is needed to catch all the floating controler windows (MDI subwindows) in a rack.
#1911

Unfortunately I don't have the time to bring this to an end. I would be happy if someone would like to take over the project.

Rossmaxx · 2022-04-16T07:54:15Z

now that the rework is about to finish, i think it's about time to pick this back up.

PhysSong · 2022-11-11T05:10:17Z

I have resolved conflicts and also made minor code improvements on my fork. @BaraMGB Do you want to enable "Allow edits from maintainers", or should I close this and open a new one? If you want, you can also pull from my fork.

zonkmachine · 2024-03-30T00:02:37Z

@BaraMGB Do you want to enable "Allow edits from maintainers", or should I close this and open a new one? If you want, you can also pull from my fork.

OK. No answer so I guess @BaraMGB is busy and you can close this PR and open a new one. I'd love to see the controllers sorted in one window.

Redesign of the Controller Rack

16203e1

Umcaruje reviewed Jul 28, 2016
View reviewed changes

BaraMGB added 5 commits July 31, 2016 16:37

makes the controller title bar themable in styles.css

f8ea0cc

change width when scroll bar is needed

e79196f

minor style corretions

ff124c2

change window width if scrollbar is needed/minor style corrections

9ba7cd7

minor corrections

8ccf0f7

BaraMGB reviewed Jul 31, 2016
View reviewed changes

BaraMGB added 3 commits August 2, 2016 14:38

change order of member variables to avoiding compiler warnings

5eb3b63

change identify method for peakcontroller dialog for avoiding subwindow

ff7cd24

detect collapse for resize window if scrollbar is not needed anymore

c7dbd45

BaraMGB reviewed Aug 2, 2016
View reviewed changes

Adds drop feature to controller

b853dc3

BaraMGB changed the title ~~Redesign of the Controller Rack~~ [WIP] Redesign of the Controller Rack Aug 10, 2016

Umcaruje mentioned this pull request Aug 25, 2016

redesign lfo controller #2999

Merged

BaraMGB mentioned this pull request Sep 1, 2016

Window title will be changed on rename track, now #3012

Merged

Umcaruje added this to the 1.3.0 milestone Sep 16, 2016

BaraMGB mentioned this pull request Jan 11, 2017

CONTROLLER RACK - Changing How It Functions Visibly #3236

Closed

RebeccaDeField added gui ux labels Jan 14, 2017

BaraMGB added 3 commits January 24, 2017 10:48

change some Headers

82da86b

rebase to master

187406e

correct artwork files

aa88b07

PhysSong reviewed Aug 28, 2019

View reviewed changes

BaraMGB added 2 commits August 28, 2019 11:55

suggested changes from code review by PhysSong

b863932

move SubWindow logic from EffectView to EffectControllerDialog

afafa21

export ControllerRackView class

9e67b38

clean up #includes in PeakControllerDialog.cpp

63a14a4

LMMS deleted a comment from LmmsBot Sep 28, 2019

ghost reviewed Oct 14, 2019

View reviewed changes

Reflexe mentioned this pull request Oct 16, 2019

Move PeakController out of core #5242

Closed

ryuukumar mentioned this pull request Jul 21, 2020

Reorganising LMMS, renaming editors and classes and everything in between (cont. #120) #5592

Closed

56 tasks

tresf mentioned this pull request Nov 11, 2020

Controller Rack - Ability to move controller modules up and down #5773

Closed

Spekular added the after-refactor PRs that will need to be rebased after the planned code refactor (#5592) label Jan 5, 2021

This was referenced Apr 27, 2022

Effects rack #6388

Closed

new roadmap for the ui/ux development #6393

Closed

Rossmaxx modified the milestones: 1.3, 1.3+ Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redesign of the Controller Rack #2944

Redesign of the Controller Rack #2944

BaraMGB commented Jul 28, 2016

Umcaruje Jul 28, 2016

Umcaruje commented Jul 28, 2016

BaraMGB commented Jul 28, 2016

BaraMGB commented Jul 31, 2016

BaraMGB Jul 31, 2016

tresf Jul 31, 2016

BaraMGB Aug 2, 2016 •

edited

Loading

BaraMGB commented Aug 10, 2016

miketurn commented Jan 13, 2017

BaraMGB commented Jan 13, 2017

miketurn commented Jan 16, 2017

karmux commented Aug 25, 2019

BaraMGB commented Aug 27, 2019

PhysSong commented Aug 29, 2019

BaraMGB commented Aug 29, 2019

PhysSong commented Aug 29, 2019

tecknixia commented Oct 14, 2019 •

edited

Loading

ghost Oct 14, 2019

BaraMGB Oct 15, 2019

ghost Oct 15, 2019

tecknixia commented Oct 15, 2019 •

edited

Loading

BaraMGB commented Oct 15, 2019

tecknixia commented Oct 23, 2019 •

edited

Loading

sound8 commented Oct 31, 2020

BaraMGB commented Nov 1, 2020

Rossmaxx commented Apr 16, 2022

PhysSong commented Nov 11, 2022

zonkmachine commented Mar 30, 2024

Redesign of the Controller Rack #2944

Are you sure you want to change the base?

Redesign of the Controller Rack #2944

Conversation

BaraMGB commented Jul 28, 2016

Umcaruje Jul 28, 2016

Choose a reason for hiding this comment

Umcaruje commented Jul 28, 2016

BaraMGB commented Jul 28, 2016

BaraMGB commented Jul 31, 2016

BaraMGB Jul 31, 2016

Choose a reason for hiding this comment

tresf Jul 31, 2016

Choose a reason for hiding this comment

BaraMGB Aug 2, 2016 • edited Loading

Choose a reason for hiding this comment

BaraMGB commented Aug 10, 2016

miketurn commented Jan 13, 2017

BaraMGB commented Jan 13, 2017

miketurn commented Jan 16, 2017

karmux commented Aug 25, 2019

BaraMGB commented Aug 27, 2019

PhysSong commented Aug 29, 2019

BaraMGB commented Aug 29, 2019

PhysSong commented Aug 29, 2019

tecknixia commented Oct 14, 2019 • edited Loading

ghost Oct 14, 2019

Choose a reason for hiding this comment

BaraMGB Oct 15, 2019

Choose a reason for hiding this comment

ghost Oct 15, 2019

Choose a reason for hiding this comment

tecknixia commented Oct 15, 2019 • edited Loading

BaraMGB commented Oct 15, 2019

tecknixia commented Oct 23, 2019 • edited Loading

sound8 commented Oct 31, 2020

BaraMGB commented Nov 1, 2020

Rossmaxx commented Apr 16, 2022

PhysSong commented Nov 11, 2022

zonkmachine commented Mar 30, 2024

BaraMGB Aug 2, 2016 •

edited

Loading

tecknixia commented Oct 14, 2019 •

edited

Loading

tecknixia commented Oct 15, 2019 •

edited

Loading

tecknixia commented Oct 23, 2019 •

edited

Loading