Arpeggiator Cycle function.

[zonkmachine]

See #2080

From the Cycle Knob's help text:

Jumps over n steps in the arpeggio and cycles around if we're over the note range.
If the total note range is evenly divisible by the number of steps jumped over you will
get stuck in a shorter arpeggio or even on one note.

...and if you do get stuck in a shorter sequence you can just turn up the Miss Knob to reach the other notes.

[zonkmachine]

This is the last of the three functions (the others being skip and miss) originally targeted for 1.2 .
Fixed up and tested.

[zonkmachine]

Merge?

[jasp00]

    // Cycle notes
    if( m_arpCycleModel.value() && dir != ArpDirRandom )
    {
        cur_arp_idx += m_arpCycleModel.value() + 1;
        cur_arp_idx %= range;
    }

[zonkmachine]

Awesome!

Though cur_arp_idx += m_arpCycleModel.value() + 1;
needs to be: cur_arp_idx *= m_arpCycleModel.value() + 1;

[zonkmachine]

OK, I'll merge this in a day if there are not other comments.

[Umcaruje]

👍