Option to allow auto save while playing #3088

zonkmachine · 2016-10-24T14:44:54Z

Since most systems have no problems saving a project while playing we could add this as an option.
The problem here is that if you edit a project while playing (or just do very short stops so the autosave doesn't have time enough to start) you may end up not getting a backup for a very long time and you wouldn't know about it.

zonkmachine · 2016-12-03T03:21:21Z

@Umcaruje I turned auto save on by default. I'm trying to do the same for the new "running auto save" setting, but inverting button logic in SetupDialog.cpp has a tendency to mess my mind up. All the way up and every time. 💫

zonkmachine · 2016-12-06T10:05:45Z

The new LED switch is going to be a bit harder to grey out than the slider.
It may be a bit confusing to leave it on when it will have no function while the auto save is otherwise turned off.

Umcaruje · 2016-12-29T23:25:55Z

@zonkmachine is this ready for testing?

zonkmachine · 2016-12-30T00:51:53Z

Yes. As I turned off 'disabling the slider' when auto save is off the action is not as clear as it was previously but it will take some effort to give the same functionality to the 'running auto save button'. Testing and feedback is appreciated.

zonkmachine · 2017-01-29T15:37:32Z

All issues solved, ready for review!

As the LED checkbox when disabled still displays it's value, and that's surprisingly confusing, I set the second option invisible instead. Works!
I also tweaked the time label to show "Disabled", when the Auto Save is off.

zonkmachine · 2017-01-29T15:50:46Z

@LMMS/artwork-team Should I move the bottom LED in a bit from the side to show that it's subordinated the Enable LED?

zonkmachine · 2017-01-29T16:37:17Z

Is the wording acceptable?
Capitalization?

tresf · 2017-01-29T16:38:28Z

I would recommend auto-save (while playing). The word "feature" can be removed.

zonkmachine · 2017-01-29T16:44:37Z

zonkmachine · 2017-01-29T16:48:25Z

Maybe just the word Disabled instead of Auto-save disabled ?

tresf · 2017-01-29T16:49:31Z

Maybe just the word Disabled instead of Auto-save disabled ?

If default is on, sure.

zonkmachine · 2017-01-29T17:22:35Z

Cleaner...

tresf · 2017-01-29T18:04:55Z

@zonkmachine the only thing that's not immediately intuitive is that the slider enables/disables this feature.

Perhaps the best of both worlds would be to make the slider and the first LED linked, or labels under the tick marks suggesting. My opinion is that auto-save should be on, always with no option to disable. If there are performance problems, we make those priority but I really don't understand why anyone wouldn't want a recovery option. Telling the software how many seconds/minutes is IMO too granular for the average user. That's my 2 cents.

zonkmachine · 2017-01-29T18:09:57Z

the slider enables/disables this feature.

It doesn't for me and it isn't supposed to.

tresf · 2017-01-29T18:11:01Z

OK I'm confused then. You've replaced a check box with a label so I'm not sure what's going on.

tresf · 2017-01-29T18:11:37Z

Or are you hiding the child check box?

zonkmachine · 2017-01-29T20:51:34Z

I'll look into it.

zonkmachine · 2017-01-30T04:49:10Z

Or are you hiding the child check box?

The Allow auto-save while playing check box is hidden when Auto save is disabled. I do this because setEnabled() doesn't grey out the check box or indicate in any way that somethings changed apart from making the check box not responding on button clicks. I thought that's a bit confusing so I hide it instead.

tresf · 2017-01-30T05:29:58Z

@zonkmachine thanks for the explanation. That makes sense.

zonkmachine · 2017-01-30T06:39:14Z

My opinion is that auto-save should be on, always with no option to disable.

I agree on having auto-save always on. I think the best take on it is what @jasp00 suggests in this comment from issue 181. Then we wouldn't need to bother about saving in a lower priority thread and can just drop the auto-save settings altogether. But for now I think this is probably the best option.

If there are performance problems, we make those priority...

One point in doing it this way is that it becomes manageable for someone who isn't an experienced coder like me. Performance was one of the first things I looked at when I started working on the auto-save function but I dropped it pretty quickly. And fundamentally changing how it's done would take someone more experienced and there are more important things to take on.

zonkmachine · 2017-02-01T11:11:40Z

I'm happy with this now. Anything else to be done here?

jasp00

This request is conceptually wrong.

jasp00 · 2017-02-04T15:06:46Z

src/gui/SetupDialog.cpp

@@ -124,7 +124,8 @@ SetupDialog::SetupDialog( ConfigTabs _tab_to_open ) :
 #endif
 	m_backgroundArtwork( QDir::toNativeSeparators( ConfigManager::inst()->backgroundArtwork() ) ),
 	m_smoothScroll( ConfigManager::inst()->value( "ui", "smoothscroll" ).toInt() ),
-	m_enableAutoSave( ConfigManager::inst()->value(	"ui", "enableautosave" ).toInt() ),
+	m_disableAutoSave( !ConfigManager::inst()->value( "ui", "disableautosave" ).toInt() ),
+	m_disableRunningAutoSave( !ConfigManager::inst()->value( "ui", "disablerunningautosave" ).toInt() ),


Double negations should be avoided; "enable" should be preferred over "disable". This code does not make sense, because it looks like:

m_disableAutoSave = !disableautosave m_disableRunningAutoSave = !disablerunningautosave

Thanks! I'm looking at clearing this up now.

jasp00 · 2017-02-04T15:08:19Z

src/gui/SetupDialog.cpp

+	m_runningAutoSave = new LedCheckBox(
+			tr( "Allow auto-save while playing" ), auto_save_tw );
+	m_runningAutoSave->move( 20, 90 );
+	m_runningAutoSave->setChecked( m_disableRunningAutoSave );


Same problem here:
runningAutoSave = disableRunningAutoSave

jasp00 · 2017-02-04T15:10:01Z

src/gui/SetupDialog.cpp

-	ConfigManager::inst()->setValue( "ui", "enableautosave",
-					QString::number( m_enableAutoSave ) );
+	ConfigManager::inst()->setValue( "ui", "disableautosave",
+					QString::number( !m_disableAutoSave ) );


Same problem:
disableautosave = !disableAutoSave

jasp00 · 2017-02-04T15:10:20Z

src/gui/SetupDialog.cpp

 	ConfigManager::inst()->setValue( "ui", "saveinterval",
 					QString::number( m_saveInterval ) );
+	ConfigManager::inst()->setValue( "ui", "disablerunningautosave",
+					QString::number( !m_disableRunningAutoSave ) );


jasp00 · 2017-02-04T15:11:46Z

src/gui/SetupDialog.cpp

 void SetupDialog::toggleAutoSave( bool _enabled )
 {
-	m_enableAutoSave = _enabled;
+	m_disableAutoSave = _enabled;


disable means enable, etc.
What is the reason?

jasp00 · 2017-02-04T15:12:53Z

src/gui/SetupDialog.cpp

-	m_saveIntervalLbl->setText( tr( "Auto save interval: %1 %2" ).arg(
-				 QString::number( m_saveInterval ), minutes ) );
+	minutes = QString( "%1 %2" ).arg( QString::number( m_saveInterval ), minutes );
+	minutes = m_disableAutoSave ?  minutes : tr( "Disabled" );


If not disable, it is disabled.

* Option to allow auto save while playing

zonkmachine added the enhancement label Oct 24, 2016

zonkmachine added this to the 1.2.0 milestone Oct 24, 2016

zonkmachine added the in progress label Oct 24, 2016

zonkmachine force-pushed the autosaveWhileRunning branch from 8b6b3a9 to ec5abd6 Compare November 29, 2016 00:17

zonkmachine force-pushed the autosaveWhileRunning branch from 1a68220 to 3e4a9b2 Compare December 6, 2016 09:58

zonkmachine removed the in progress label Dec 6, 2016

zonkmachine force-pushed the autosaveWhileRunning branch from 3e4a9b2 to fa15c31 Compare December 13, 2016 12:15

zonkmachine force-pushed the autosaveWhileRunning branch from fa15c31 to 2e32cd5 Compare January 29, 2017 15:32

zonkmachine force-pushed the autosaveWhileRunning branch from 2e32cd5 to d435e76 Compare January 29, 2017 16:38

zonkmachine force-pushed the autosaveWhileRunning branch from d435e76 to b404109 Compare January 29, 2017 16:46

Option to allow auto save while playing

6965774

zonkmachine force-pushed the autosaveWhileRunning branch from b404109 to 6965774 Compare January 29, 2017 17:29

Clear up logic and bug in button tool tip

b649a95

fixup

a7d5cc5

zonkmachine merged commit c54171b into LMMS:master Feb 1, 2017

zonkmachine deleted the autosaveWhileRunning branch February 1, 2017 16:06

jasp00 reviewed Feb 4, 2017

View reviewed changes

This was referenced May 10, 2017

Fix regression where autosave function is off by default #3541

Closed

Provide support for fallback config values #3551

Merged

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022

Option to allow auto save while playing (LMMS#3088)

785fc84

* Option to allow auto save while playing

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Option to allow auto save while playing #3088

Option to allow auto save while playing #3088

zonkmachine commented Oct 24, 2016 •

edited

Loading

zonkmachine commented Dec 3, 2016

zonkmachine commented Dec 6, 2016 •

edited

Loading

Umcaruje commented Dec 29, 2016

zonkmachine commented Dec 30, 2016

zonkmachine commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

tresf commented Jan 29, 2017 •

edited

Loading

zonkmachine commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

tresf commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

tresf commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

tresf commented Jan 29, 2017

tresf commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

zonkmachine commented Jan 30, 2017

tresf commented Jan 30, 2017

zonkmachine commented Jan 30, 2017

zonkmachine commented Feb 1, 2017

jasp00 left a comment

jasp00 Feb 4, 2017

zonkmachine Feb 6, 2017

zonkmachine Feb 6, 2017

jasp00 Feb 4, 2017

zonkmachine Feb 6, 2017

jasp00 Feb 4, 2017

zonkmachine Feb 6, 2017

jasp00 Feb 4, 2017

jasp00 Feb 4, 2017

jasp00 Feb 4, 2017

Option to allow auto save while playing #3088

Option to allow auto save while playing #3088

Conversation

zonkmachine commented Oct 24, 2016 • edited Loading

zonkmachine commented Dec 3, 2016

zonkmachine commented Dec 6, 2016 • edited Loading

Umcaruje commented Dec 29, 2016

zonkmachine commented Dec 30, 2016

zonkmachine commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

tresf commented Jan 29, 2017 • edited Loading

zonkmachine commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

tresf commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

tresf commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

tresf commented Jan 29, 2017

tresf commented Jan 29, 2017

zonkmachine commented Jan 29, 2017

zonkmachine commented Jan 30, 2017

tresf commented Jan 30, 2017

zonkmachine commented Jan 30, 2017

zonkmachine commented Feb 1, 2017

jasp00 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zonkmachine commented Oct 24, 2016 •

edited

Loading

zonkmachine commented Dec 6, 2016 •

edited

Loading

tresf commented Jan 29, 2017 •

edited

Loading