Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph: add Control+click feature for compressor usage #3140

Closed
wants to merge 1 commit into from
Closed

Graph: add Control+click feature for compressor usage #3140

wants to merge 1 commit into from

Conversation

DeRobyJ
Copy link
Contributor

@DeRobyJ DeRobyJ commented Dec 1, 2016

Ctrl+click now creates two lines for a compressor-like graph, to use in Waveshaper and Dynamics Processor.

I had to set the initial and start values because the drawLineAt method changes the final values of the line slightly, so using ctrl+click multiple times would result in first and last values being changed.

In my opinion, this needs some fixes, but I felt like sharing it anyway.

My original intent was not to reset initial and final values, but to keep old ones and draw lines using those values and the mouse position. This would have allowed for more generalist usage, like for Multitap Echo.

pizza3
(in this screen, I used the new feature and then pressed "-1dB" some times)

@Umcaruje
Copy link
Member

I would find this confusing like a user. A better solution would be to actually add ratio/knee/threshold knobs to the dynamic processor and have a freeline mode that would turn the knobs off for drawing custom curves.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Dec 30, 2016

Well the two features aren't contrasting. We may have both

@Umcaruje Umcaruje changed the base branch from master to stable-1.2 March 26, 2017 11:38
@JohannesLorenz
Copy link
Contributor

As this is a feature and stable-1.2 has feature freeze for a long time, can you please re-target this to master?

@zonkmachine zonkmachine changed the base branch from stable-1.2 to master December 14, 2019 19:18
@PhysSong
Copy link
Member

For compressor, now there is #5458.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Apr 28, 2020

Of course, and it's magnificent!

That said, that is a Compressor, a mixing effect, this is a Wave Shaper, a sound design tool!

My wording wasn't really clear when I did this pull request. If you feel that this feature is not useful anymore, I'm ok with it. I just have one question before closing it: when ad how do you use the Waveshaper? What shapes do you draw?

When I did this change, I did it because every time I used the waveshaper I had to draw that compressor-like shape. Maybe that's just my case.

@LostRobotMusic
Copy link
Contributor

The feature requested here will be resolved by #4367.

@DeRobyJ
Copy link
Contributor Author

DeRobyJ commented Apr 28, 2020

Oh, then I guess I can close this ahah

Great stuff!

@DeRobyJ DeRobyJ closed this Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants