Mallets, turn off excessive warnings #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STK is a bit too happy about messaging and I think we can spare the user from this. I also thought it could be a good idea to make the warnings visible if on a debug build
-DCMAKE_BUILD_TYPE=DEBUGbut that has failed me so far and it isn't a big thing to turn the messages on when needed anyway.Note:
The warnings still need to be addressed though. I've taken care of most of them but at least one remains:
OnePole::setPole: argument (1) should be less than 1.0!