Offbeatnotes #3361
Offbeatnotes #3361
Conversation
src/gui/editors/PianoRoll.cpp
Outdated
| @@ -2451,7 +2451,7 @@ void PianoRoll::dragNotes( int x, int y, bool alt, bool shift, bool ctrl ) | |||
|
|
|||
| note->setPos( MidiTime( pos_ticks ) ); | |||
| note->setKey( key_num ); | |||
| if( note->length() <= 0 ) | |||
| if( note->length() < 0 ) | |||
There was a problem hiding this comment.
Because '0' length notes are no more.
|
Needs testing/review. The first change is pretty straight forward and I think 'merge is go' for that one. As for the second change I have no better idea on store. It works as it is but it's probably a matter of taste more than anything else. Pros, there are no more hidden notes in BBTracks and it's easy to implement. If you add or drag a note off beat you get an instant representation of it as the pattern is updated. Cons, you maybe simply prefer the older way and if you have more than one off beat note it may be annoying to find them to go back to a BBTrack. Maybe off beat beat track notes could be given a diffferent colour in the song editor? |
zonkmachine
force-pushed
the
offbeatnotes
branch
from
39c9bb9 to
9e791ce
Compare
zonkmachine
force-pushed
the
offbeatnotes
branch
from
9e791ce to
025b474
Compare
Merged in #3375, the other feature needs review. |
| @@ -88,7 +88,7 @@ class EXPORT Pattern : public TrackContentObject | |||
| { | |||
| return m_patternType; | |||
| } | |||
|
|
|||
| void checkType(); | |||
|
|
|||
There was a problem hiding this comment.
I made this public to be able to call it from PianoRoll.cpp .
|
Merge? |
|
No objections so I will merge this tomorrow. |
|
@jasp00 Unfortunately this breaks the upgrade of void DataFile::upgrade_1_2_0_rc3() |
Fixes #1681
From a discussion that starts here: #1681 (comment)
When you add an ordinary note to a beat pattern the pattern is visually turned into a melody pattern, but the beat notes aren't represented in it.Fixed in Visible beat notes in MelodyPattern #3375Suggested fix: Pattern switch to MelodyPattern when one or more beat notes are not visible in the BBEditor.