Remove non-document menu icons on macOS / OS X #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Displaying menu icons on macOS/OS X does not fit the standard OS guidelines unless they represent documents. See LMMS#3349. Note: Requires a follow up Qt bug workaround to show icons in some submenus.
tresf
reviewed
Feb 16, 2017
src/gui/MainWindow.cpp
Outdated
| @@ -893,6 +893,10 @@ void MainWindow::updateRecentlyOpenedProjectsMenu() | |||
| { | |||
| m_recentlyOpenedProjectsMenu->addAction( | |||
| embed::getIconPixmap( "project_file" ), *it ); | |||
| #ifdef LMMS_BUILD_APPLE | |||
| m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false); // Workaround for https://bugreports.qt.io/browse/QTBUG-44565 | |||
There was a problem hiding this comment.
I feel this would be cleaner
m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false); // Per QTBUG-44565
m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(true);Alternately, you could put the comment on it's own line, which has the downside of taking it slightly out of context.
There was a problem hiding this comment.
I did wonder about URL vs bug number but went with the full URL since that's what we used in #3350.
I'd tend toward still indicating it's a workaround, so would prefer to go with:
m_recentlyOpenedProjectsMenu->actions().last()->setIconVisibleInMenu(false); // QTBUG-44565 workaround
|
Thanks for helping getting this in merge-able state and merging it! :) |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Remove icons from non-document menus on macOS Matches Apple user interface guidelines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #3349