Don't count muted tracks in track length #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonkmachine
force-pushed
the
renderlength
branch
from
f5ace0e to
f93e113
Compare
zonkmachine
force-pushed
the
renderlength
branch
from
f93e113 to
f81f6f2
Compare
|
|
|
I am not sure this was a bug. Mute buttons can be automated, so a muted track could be part of an export. I am not certain "mute" should equal "disable". If it does, automation for these buttons should be dropped and an upgrade path should be written. |
|
@jasp00 OK. I won't have time to fix this so proceed as you see fit or revert. |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
* Don't count muted tracks to length on render * Don't count muted TCO's to length on render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1733
When rendering, don't count muted tracks in
Song::updateLength()or muted TCO's inTrack::length()Edit2: This seem to work just fine.