-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VeSTige opens correct folder #3550
Conversation
…STige instruments.
33c7b5a
to
8548b7d
Compare
@karmux thanks. First, what happens if the VST does not exist at the given path? Does it know to fallback to the VST directory? Second, have you considered consolidating this into the Reason being... we already have areas where the existing constructor could simplify the code since the existing constructor supports |
… exist at the given path.
@tresf Good that you asked that. It didn't default to configured VST plugin directory if the VST plugin did not exist at the given path. SF2 and GIG players seemed to default to plugins directory defined in config. I fixed this in similar way to GIG Player. I was thinking about some general helper functionality for all these instrument plugins but that would be safer to implement for next version after 1.2 I think. |
The only concern I have is with the way we display the error message with this PR. Previously, if a vst was in |
@karmux thanks! |
Open correct VST folder in previously saved projects with existing VeSTige instruments.
Open correct VST folder in previously saved projects with existing VeSTige instruments.
Open correct VST folder in previously saved projects with existing VeSTige instruments.
This pull request fixes opening correct VST folder in previously saved projects with existing VeSTige instruments. Project has to be saved using code in this PR. After next project load VST folders open correctly. Copied logic from SF2 and GIG Players.