Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the names of patterns in their tool tip #3707

Merged

Conversation

michaelgregorius
Copy link
Contributor

Adjust PatternView::update to show the name of the pattern as the tool tip (regardless of whether it is a beat and bassline or a melody pattern).

Override the public slot TrackContentObjectView::update for AutomationPatternView and BBTCOView. Implement it similar to PatternView::update.

@michaelgregorius
Copy link
Contributor Author

@tresf, @Umcaruje This one implements the tool tip changes that we discussed in #3704.

@PhysSong
Copy link
Member

@michaelgregorius How about previous tooltips? Do you think it is fine to remove them?

@michaelgregorius
Copy link
Contributor Author

@PhysSong I think we can remove the previous tool tips. There seems to be some consensus that the help system should work differently anyway.

If some work is done on a new help system the texts can be added again. They seemed a bit strange anyway as most of them started with lower case letters.

@michaelgregorius
Copy link
Contributor Author

@Umcaruje Can you please review?

The sample track already shows the file name in the tool tip if a sample was loaded. I now wonder whether it makes sense to also give it a text label which shows the filename as it is the only one that has none:

3674-consistent-patterns

The downside would be that this label would be shown all the time as it is not possible to set a new name / label.

@mikobuntu
Copy link
Contributor

@michaelgregorius I agree with giving the sample track a text label to keep it consistent with the other tracks. If the user wants to remove it we have the " reset name " switch for this anyway. keeping the tooltip will do no harm in my humble opinion.

@tresf
Copy link
Member

tresf commented Jul 21, 2017

@mikobuntu I think his point was this "reset name" feature hasn't been implemented yet for SampleTrack, so it's all or nothing.

screen shot 2017-07-20 at 11 09 52 pm

@PhysSong
Copy link
Member

And rename, too.

@mikobuntu
Copy link
Contributor

mikobuntu commented Jul 21, 2017

@tresf I see, in that case i think text labels should be implemented for the sample track. I say this because I've just noticed that the way it is now ( with only having a tooltip ) and having sample folders within sample folders on my box that the text string in the tooltip can be extremely long ( and confusing ) especially with some of my sample naming conventions.
And +1 for showing the name of the pattern in the tooltip ( per the original feature pull request ) instead of the 'hint' text.

@michaelgregorius
Copy link
Contributor Author

How about showing the file name without path in the label and showing the full path in the tool tip?

3707-sampletracklabel

@PhysSong
Copy link
Member

PhysSong commented Jul 26, 2017

How about showing the file name without path in the label and showing the full path in the tool tip?

👍

@michaelgregorius michaelgregorius force-pushed the PatternNamesAsToolTips branch from 63e64eb to 9a47b83 Compare July 26, 2017 19:14
@michaelgregorius
Copy link
Contributor Author

Showing the file name without path in the label has been pushed with commit 379e102:

3707-sampletracklabel

Adjust PatternView::update to show the name of the pattern as the tool
tip (regardless of whether it is a beat and bassline or a melody
pattern).

Override the public slot TrackContentObjectView::update for
AutomationPatternView and BBTCOView. Implement it similar to
PatternView::update.
@michaelgregorius michaelgregorius force-pushed the PatternNamesAsToolTips branch from 9a47b83 to 1f84b1b Compare July 27, 2017 14:50
@michaelgregorius michaelgregorius merged commit 9d92ea2 into LMMS:master Jul 27, 2017
@michaelgregorius michaelgregorius deleted the PatternNamesAsToolTips branch July 27, 2017 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants