-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show the names of patterns in their tool tip #3707
Show the names of patterns in their tool tip #3707
Conversation
@michaelgregorius How about previous tooltips? Do you think it is fine to remove them? |
@PhysSong I think we can remove the previous tool tips. There seems to be some consensus that the help system should work differently anyway. If some work is done on a new help system the texts can be added again. They seemed a bit strange anyway as most of them started with lower case letters. |
@Umcaruje Can you please review? The sample track already shows the file name in the tool tip if a sample was loaded. I now wonder whether it makes sense to also give it a text label which shows the filename as it is the only one that has none: The downside would be that this label would be shown all the time as it is not possible to set a new name / label. |
@michaelgregorius I agree with giving the sample track a text label to keep it consistent with the other tracks. If the user wants to remove it we have the " reset name " switch for this anyway. keeping the tooltip will do no harm in my humble opinion. |
@mikobuntu I think his point was this "reset name" feature hasn't been implemented yet for SampleTrack, so it's all or nothing. |
And rename, too. |
@tresf I see, in that case i think text labels should be implemented for the sample track. I say this because I've just noticed that the way it is now ( with only having a tooltip ) and having sample folders within sample folders on my box that the text string in the tooltip can be extremely long ( and confusing ) especially with some of my sample naming conventions. |
👍 |
63e64eb
to
9a47b83
Compare
Showing the file name without path in the label has been pushed with commit 379e102: |
Adjust PatternView::update to show the name of the pattern as the tool tip (regardless of whether it is a beat and bassline or a melody pattern). Override the public slot TrackContentObjectView::update for AutomationPatternView and BBTCOView. Implement it similar to PatternView::update.
9a47b83
to
1f84b1b
Compare
Adjust
PatternView::update
to show the name of the pattern as the tool tip (regardless of whether it is a beat and bassline or a melody pattern).Override the public slot
TrackContentObjectView::update
forAutomationPatternView
andBBTCOView
. Implement it similar toPatternView::update
.