Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save track height under a separate name, 'trackheight' #3840

Merged
merged 1 commit into from
Oct 2, 2017

Conversation

zonkmachine
Copy link
Member

Temporary fix for #3721.

@zonkmachine
Copy link
Member Author

@PhysSong Merge?

@PhysSong
Copy link
Member

PhysSong commented Oct 2, 2017

It should work without compatibility problem, but I want to know how @michaelgregorius thinks.

@michaelgregorius
Copy link
Contributor

So if I understand correctly then files stored with this patch will differentiate between trackheight which stores the height of the track as shown in the Song Editor and height which stores the height of the instrument window. Therefore loading and saving of such new files will work without the two classes interfering with each other. If an old file is loaded the new attribute trackheight will not be found and in these cases the tracks will be restored to their default height. Is this correct? If that's the case then the patch looks good to me.

@zonkmachine, @PhysSong: Thanks for working on this issue!

@zonkmachine
Copy link
Member Author

Is this correct?

Correct. I've tested this and it fixes the issue. Merge?

@michaelgregorius
Copy link
Contributor

@zonkmachine I'd say let's merge this.

@zonkmachine zonkmachine merged commit 29d8734 into LMMS:master Oct 2, 2017
@zonkmachine zonkmachine deleted the trackheight branch October 2, 2017 13:10
@zonkmachine
Copy link
Member Author

🚜

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants