Fix #3842: Opening a project with LB302 with specific waveforms produces a noise burst. #3844
+23
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the noise burst described in LMMS#3842 by removing the second initialization of vca_a to 9 in the constructor of lb302Synth.
Move the initialization of the members belonging to the VCA into lb302Synth's constructor initializer list. This also removes a duplication initialization of vca_mode from the code.
Replace the integer encoding of the VCA mode with an enumeration.
zonkmachine
approved these changes
Sep 30, 2017
|
Fix confirmed. Code looks fine... |
|
I don't know where but I vaguely remember suggesting this should go in master/1.3. |
|
8ad46aa is now in stable-1.2 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem described in #3842 by removing a duplicate initialization of a VCA variable. Also clean up some code by