Fix preset preview issues with peak controller(s) #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PhysSong If you don't create the peak controller(s), the preset may sound totally different. Which just brings this other issue #3906 . OTOH, the consequences of creating these temporary controllers are still unknown but I didn't notice anything strange so far (after fixing some double-ckick bugs in the file browser). |
|
@gi0e5b06 That is a long-standing issue. However, your suggestion doesn't look harmful for me. I 'll look into this more. 😄 |
PhysSong
force-pushed
the
peakcontrollerpreview
branch
from
2ba4761 to
6768102
Compare
|
Partially switched to @gi0e5b06's approach. Waiting for tests... |
|
Tests fine. Issue fixed with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3897.
This PR ensures peak controller effects from preview track don't instantiate a peak controller and replaces itself to a dummy effect by setting
m_okaytofalse.Here's a preset for test: PeakController.xpf.zip