Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "What's This?" and update tooltips. #4128

Merged
merged 18 commits into from
Jun 5, 2018
+640 −1,845
Merged

Remove "What's This?" and update tooltips. #4128

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
90f4253
Remove "What's This?".
Jan 23, 2018
e385c11
Remove an unused variable.
Jan 27, 2018
9de7bf3
Update main-window tooltips.
Feb 9, 2018
c2183c5
Update Song-Editor tooltips.
Feb 9, 2018
a8d6d6f
Update time line tooltips.
Feb 9, 2018
e41d741
Update Piano-Roll tooltips.
Feb 9, 2018
95bb754
Update Automation-Editor tooltips.
Feb 9, 2018
8c33b7b
Update LFO Controller tooltips.
Feb 9, 2018
ba834b8
Update LMMS plugins text.
Feb 22, 2018
85e48e5
Update track and instrument text.
Mar 15, 2018
d5f4b4d
DualFilter fix.
Mar 15, 2018
8b93281
Merge branch 'master' into WhatsThis
PhysSong Mar 16, 2018
2ef9cc8
Fix a missing semicolon
PhysSong Mar 16, 2018
892a7d2
Remove redundant `/*`
PhysSong Mar 16, 2018
2e15118
Merge branch 'master' into WhatsThis
PhysSong May 4, 2018
0966eb4
Merge branch 'master' into WhatsThis
PhysSong May 18, 2018
211c51e
Fixes
Jun 3, 2018
7cb370c
Fix
Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions include/CaptionMenu.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,6 @@ class EXPORT CaptionMenu : public QMenu
public:
CaptionMenu( const QString & _title, QWidget * _parent = 0 );
virtual ~CaptionMenu();

///
/// \brief Adds a "Help" action displaying the Menu's parent's WhatsThis
/// text when selected.
///
void addHelpAction();

} ;


Expand Down
1 change: 0 additions & 1 deletion include/ControllerView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ class ControllerView : public QFrame, public ModelView
public slots:
void editControls();
void deleteController();
void displayHelp();
void closeControls();
void renameController();

Expand Down
1 change: 0 additions & 1 deletion include/EffectView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ public slots:
void moveUp();
void moveDown();
void deletePlugin();
void displayHelp();
void closeEffects();


Expand Down
1 change: 0 additions & 1 deletion include/FxLine.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@ private slots:
void removeUnusedChannels();
void moveChannelLeft();
void moveChannelRight();
void displayHelp();
};


Expand Down
1 change: 0 additions & 1 deletion include/Knob.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ class EXPORT Knob : public QWidget, public FloatModelView

private slots:
virtual void enterValue();
void displayHelp();
void friendlyUpdate();
void toggleScale();

Expand Down
1 change: 0 additions & 1 deletion include/MainWindow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ public slots:
void resetWindowTitle();

void emptySlot();
void enterWhatsThisMode();
void createNewProject();
void createNewProjectFromTemplate( QAction * _idx );
void openProject();
Expand Down
4 changes: 0 additions & 4 deletions include/SetupDialog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ private slots:
// general settings widget
void setBufferSize( int _value );
void resetBufSize();
void displayBufSizeHelp();

// path settings widget
void setWorkingDir( const QString & _wd );
Expand All @@ -86,15 +85,12 @@ private slots:
// performance settings widget
void setAutoSaveInterval( int time );
void resetAutoSave();
void displaySaveIntervalHelp();

// audio settings widget
void audioInterfaceChanged( const QString & _driver );
void displayAudioHelp();

// MIDI settings widget
void midiInterfaceChanged( const QString & _driver );
void displayMIDIHelp();


void toggleToolTips( bool _enabled );
Expand Down
18 changes: 0 additions & 18 deletions plugins/FreeBoy/FreeBoy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,39 +467,30 @@ FreeBoyInstrumentView::FreeBoyInstrumentView( Instrument * _instrument,
m_ch1SweepTimeKnob->setHintText( tr( "Sweep Time:" ), "" );
m_ch1SweepTimeKnob->move( 5 + 4*32, 106 );
ToolTip::add( m_ch1SweepTimeKnob, tr( "Sweep Time" ) );
m_ch1SweepTimeKnob->setWhatsThis( tr( "The amount of increase or"
" decrease in frequency" ) );

m_ch1SweepRtShiftKnob = new FreeBoyKnob( this );
m_ch1SweepRtShiftKnob->setHintText( tr( "Sweep RtShift amount:" )
, "" );
m_ch1SweepRtShiftKnob->move( 5 + 3*32, 106 );
ToolTip::add( m_ch1SweepRtShiftKnob, tr( "Sweep RtShift amount" ) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tooltips are very vague, I think the whatsthis text(or a shorter version of it) should become the tooltip text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Many tooltips will be updated, and created.

m_ch1SweepRtShiftKnob->setWhatsThis( tr( "The rate at which increase or"
" decrease in frequency occurs" ) );

m_ch1WavePatternDutyKnob = new FreeBoyKnob( this );
m_ch1WavePatternDutyKnob->setHintText( tr( "Wave pattern duty:" )
, "" );
m_ch1WavePatternDutyKnob->move( 5 + 2*32, 106 );
ToolTip::add( m_ch1WavePatternDutyKnob, tr( "Wave Pattern Duty" ) );
m_ch1WavePatternDutyKnob->setWhatsThis( tr( "The duty cycle is the ratio of"
" the duration (time) that a signal is ON"
" versus the total period of the signal." ) );

m_ch1VolumeKnob = new FreeBoyKnob( this );
m_ch1VolumeKnob->setHintText( tr( "Square Channel 1 Volume:" )
, "" );
m_ch1VolumeKnob->move( 5, 106 );
ToolTip::add( m_ch1VolumeKnob, tr( "Square Channel 1 Volume:" ) );
m_ch1VolumeKnob->setWhatsThis( tr( "Square Channel 1 Volume" ) );

m_ch1SweepStepLengthKnob = new FreeBoyKnob( this );
m_ch1SweepStepLengthKnob->setHintText( tr( "Length of each step in sweep:" )
, "" );
m_ch1SweepStepLengthKnob->move( 5 + 32, 106 );
ToolTip::add( m_ch1SweepStepLengthKnob, tr( "Length of each step in sweep" ) );
m_ch1SweepStepLengthKnob->setWhatsThis( tr( "The delay between step change" ) );



Expand All @@ -508,46 +499,38 @@ FreeBoyInstrumentView::FreeBoyInstrumentView( Instrument * _instrument,
, "" );
m_ch2WavePatternDutyKnob->move( 5 + 2*32, 155 );
ToolTip::add( m_ch2WavePatternDutyKnob, tr( "Wave pattern duty" ) );
m_ch2WavePatternDutyKnob->setWhatsThis( tr( "The duty cycle is the ratio of"
" the duration (time) that a signal is ON"
" versus the total period of the signal." ) );

m_ch2VolumeKnob = new FreeBoyKnob( this );
m_ch2VolumeKnob->setHintText( tr( "Square Channel 2 Volume:" )
, "" );
m_ch2VolumeKnob->move( 5, 155 );
ToolTip::add( m_ch2VolumeKnob, tr( "Square Channel 2 Volume" ) );
m_ch2VolumeKnob->setWhatsThis( tr( "Square Channel 2 Volume" ) );

m_ch2SweepStepLengthKnob = new FreeBoyKnob( this );
m_ch2SweepStepLengthKnob->setHintText( tr( "Length of each step in sweep:" )
, "" );
m_ch2SweepStepLengthKnob->move( 5 + 32, 155 );
ToolTip::add( m_ch2SweepStepLengthKnob, tr( "Length of each step in sweep" ) );
m_ch2SweepStepLengthKnob->setWhatsThis( tr( "The delay between step change" ) );



m_ch3VolumeKnob = new FreeBoyKnob( this );
m_ch3VolumeKnob->setHintText( tr( "Wave Channel Volume:" ), "" );
m_ch3VolumeKnob->move( 5, 204 );
ToolTip::add( m_ch3VolumeKnob, tr( "Wave Channel Volume" ) );
m_ch3VolumeKnob->setWhatsThis( tr( "Wave Channel Volume" ) );



m_ch4VolumeKnob = new FreeBoyKnob( this );
m_ch4VolumeKnob->setHintText( tr( "Noise Channel Volume:" ), "" );
m_ch4VolumeKnob->move( 144, 155 );
ToolTip::add( m_ch4VolumeKnob, tr( "Noise Channel Volume" ) );
m_ch4VolumeKnob->setWhatsThis( tr( "Noise Channel Volume" ) );

m_ch4SweepStepLengthKnob = new FreeBoyKnob( this );
m_ch4SweepStepLengthKnob->setHintText( tr( "Length of each step in sweep:" )
, "" );
m_ch4SweepStepLengthKnob->move( 144 + 32, 155 );
ToolTip::add( m_ch4SweepStepLengthKnob, tr( "Length of each step in sweep" ) );
m_ch4SweepStepLengthKnob->setWhatsThis( tr( "The delay between step change" ) );



Expand Down Expand Up @@ -691,7 +674,6 @@ FreeBoyInstrumentView::FreeBoyInstrumentView( Instrument * _instrument,
m_graph->move( 37, 199 );
m_graph->resize(208, 47);
ToolTip::add( m_graph, tr( "Wave Pattern" ) );
m_graph->setWhatsThis( tr( "Draw the wave here" ) );
}


Expand Down
11 changes: 0 additions & 11 deletions plugins/GigPlayer/GigPlayer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,8 +940,6 @@ GigInstrumentView::GigInstrumentView( Instrument * _instrument, QWidget * _paren

ToolTip::add( m_fileDialogButton, tr( "Open other GIG file" ) );

m_fileDialogButton->setWhatsThis( tr( "Click here to open another GIG file" ) );

// Patch Button
m_patchDialogButton = new PixmapButton( this );
m_patchDialogButton->setCursor( QCursor( Qt::PointingHandCursor ) );
Expand All @@ -954,32 +952,23 @@ GigInstrumentView::GigInstrumentView( Instrument * _instrument, QWidget * _paren

ToolTip::add( m_patchDialogButton, tr( "Choose the patch" ) );

m_patchDialogButton->setWhatsThis( tr( "Click here to change which patch of the GIG file to use" ) );

// LCDs
m_bankNumLcd = new LcdSpinBox( 3, "21pink", this );
m_bankNumLcd->move( 111, 150 );

m_patchNumLcd = new LcdSpinBox( 3, "21pink", this );
m_patchNumLcd->move( 161, 150 );

m_bankNumLcd->setWhatsThis( tr( "Change which instrument of the GIG file is being played" ) );
m_patchNumLcd->setWhatsThis( tr( "Change which instrument of the GIG file is being played" ) );

// Next row
m_filenameLabel = new QLabel( this );
m_filenameLabel->setGeometry( 61, 70, 156, 14 );
m_patchLabel = new QLabel( this );
m_patchLabel->setGeometry( 61, 94, 156, 14 );

m_filenameLabel->setWhatsThis( tr( "Which GIG file is currently being used" ) );
m_patchLabel->setWhatsThis( tr( "Which patch of the GIG file is currently being used" ) );

// Gain
m_gainKnob = new gigKnob( this );
m_gainKnob->setHintText( tr( "Gain" ) + " ", "" );
m_gainKnob->move( 32, 140 );
m_gainKnob->setWhatsThis( tr( "Factor to multiply samples by" ) );

setAutoFillBackground( true );
QPalette pal;
Expand Down
17 changes: 0 additions & 17 deletions plugins/VstEffect/VstEffectControlDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,6 @@ VstEffectControlDialog::VstEffectControlDialog( VstEffectControls * _ctl ) :
SLOT( managePlugin() ) );
ToolTip::add( m_managePluginButton, tr( "Control VST-plugin from LMMS host" ) );

m_managePluginButton->setWhatsThis(
tr( "Click here, if you want to control VST-plugin from host." ) );

m_managePluginButton->setMinimumWidth( 26 );
m_managePluginButton->setMaximumWidth( 26 );
m_managePluginButton->setMinimumHeight( 21 );
Expand All @@ -126,9 +123,6 @@ VstEffectControlDialog::VstEffectControlDialog( VstEffectControls * _ctl ) :
SLOT( openPreset() ) );
ToolTip::add( m_openPresetButton, tr( "Open VST-plugin preset" ) );

m_openPresetButton->setWhatsThis(
tr( "Click here, if you want to open another *.fxp, *.fxb VST-plugin preset." ) );

m_openPresetButton->setMinimumWidth( 16 );
m_openPresetButton->setMaximumWidth( 16 );
m_openPresetButton->setMinimumHeight( 16 );
Expand All @@ -151,9 +145,6 @@ VstEffectControlDialog::VstEffectControlDialog( VstEffectControls * _ctl ) :

m_rolLPresetButton->setShortcut( Qt::Key_Minus );

m_rolLPresetButton->setWhatsThis(
tr( "Click here, if you want to switch to another VST-plugin preset program." ) );

m_rolLPresetButton->setMinimumWidth( 16 );
m_rolLPresetButton->setMaximumWidth( 16 );
m_rolLPresetButton->setMinimumHeight( 16 );
Expand All @@ -176,9 +167,6 @@ VstEffectControlDialog::VstEffectControlDialog( VstEffectControls * _ctl ) :

m_rolRPresetButton->setShortcut( Qt::Key_Plus );

m_rolRPresetButton->setWhatsThis(
tr( "Click here, if you want to switch to another VST-plugin preset program." ) );

m_rolRPresetButton->setMinimumWidth( 16 );
m_rolRPresetButton->setMaximumWidth( 16 );
m_rolRPresetButton->setMinimumHeight( 16 );
Expand All @@ -189,8 +177,6 @@ VstEffectControlDialog::VstEffectControlDialog( VstEffectControls * _ctl ) :
_ctl->m_selPresetButton->setCheckable( false );
_ctl->m_selPresetButton->setCursor( Qt::PointingHandCursor );
_ctl->m_selPresetButton->setIcon( embed::getIconPixmap( "stepper-down" ) );
_ctl->m_selPresetButton->setWhatsThis(
tr( "Click here to select presets that are currently loaded in VST." ) );

_ctl->m_selPresetButton->setMenu(_ctl->menu);

Expand All @@ -210,9 +196,6 @@ VstEffectControlDialog::VstEffectControlDialog( VstEffectControls * _ctl ) :
SLOT( savePreset() ) );
ToolTip::add( m_savePresetButton, tr( "Save preset" ) );

m_savePresetButton->setWhatsThis(
tr( "Click here, if you want to save current VST-plugin preset program." ) );

m_savePresetButton->setMinimumWidth( 21 );
m_savePresetButton->setMaximumWidth( 21 );
m_savePresetButton->setMinimumHeight( 21 );
Expand Down
6 changes: 0 additions & 6 deletions plugins/VstEffect/VstEffectControls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,25 +327,19 @@ manageVSTEffectView::manageVSTEffectView( VstEffect * _eff, VstEffectControls *
m_syncButton = new QPushButton( tr( "VST Sync" ), widget );
connect( m_syncButton, SIGNAL( clicked() ), this,
SLOT( syncPlugin() ) );
m_syncButton->setWhatsThis(
tr( "Click here if you want to synchronize all parameters with VST plugin." ) );

l->addWidget( m_syncButton, 0, 0, 1, 2, Qt::AlignLeft );

m_displayAutomatedOnly = new QPushButton( tr( "Automated" ), widget );
connect( m_displayAutomatedOnly, SIGNAL( clicked() ), this,
SLOT( displayAutomatedOnly() ) );
m_displayAutomatedOnly->setWhatsThis(
tr( "Click here if you want to display automated parameters only." ) );

l->addWidget( m_displayAutomatedOnly, 0, 1, 1, 2, Qt::AlignLeft );


m_closeButton = new QPushButton( tr( " Close " ), widget );
connect( m_closeButton, SIGNAL( clicked() ), this,
SLOT( closeWindow() ) );
m_closeButton->setWhatsThis(
tr( "Close VST effect knob-controller window." ) );

l->addWidget( m_closeButton, 0, 2, 1, 7, Qt::AlignLeft );

Expand Down
Loading