Piano Roll - Erase on mouse button drag in erase mode #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review please! I think this fix is adequate for 1.2 . Maybe it's better to remove the eraser completely and just use the erase functionality in draw mode, but it seem a bit more intrusive this close to release. |
i cant find a link |
|
? |
You mean link to a binary? I don't build win binaries. Instructions on reviewing a PR is here: This PR is already merged and you can test this in any later binary based on stable-1.2 . |
Ok :') |
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erase tool in Piano Roll will erase on clicking a note but not when keeping a button down while moving the cursor over a note. With this fix keeping any key down and moving over a note will delete it.
Fixes #980