Add option to show note values on notes in Piano Roll (#4466) #4467
Conversation
Add the option to show note values on notes in the Piano Roll. This functionality is currently coupled with the option "Enable note labels in piano roll" which can be found in the main menu. The notes are rendered at about 80% of the notes height. They are only rendered if they fit on the whole note and if the font does not become too tiny. Enable the configuration of the note value text's color via the stylesheets and set the value to white for both shipped themes. Other changes: * Clean up some warnings about old school casts and implicit casts.
data/themes/classic/style.css
Outdated
| @@ -123,6 +123,7 @@ PianoRoll { | |||
| qproperty-backgroundShade: rgba( 255, 255, 255, 10 ); | |||
| qproperty-noteModeColor: rgb( 255, 255, 255 ); | |||
| qproperty-noteColor: rgb( 119, 199, 216 ); | |||
| qproperty-noteTextColor: rgb( 255, 255, 255 ); | |||
There was a problem hiding this comment.
Should probably use tab indentation instead of spaces to match the style of the surrounding lines (same with the change to data/themes/default/style.css).
There was a problem hiding this comment.
Done with 27bd8aa.
src/gui/editors/PianoRoll.cpp
Outdated
| { | ||
| p.setPen(noteTextColor); | ||
| p.setFont(noteFont); | ||
| QPoint textStart(x + xOffset, y + (noteTextHeight + (noteHeight - noteTextHeight) / 2)); |
There was a problem hiding this comment.
For what it's worth, the calculation of the y-coordinate (baseline) could be expressed more succinctly as y + (noteHeight + noteTextHeight) / 2.
There was a problem hiding this comment.
Done with 27bd8aa.
Use tabs in the style sheets. Make the calculation of the Y offset more concise.
|
@Wallacoloo Thanks for the code review! I have implemented all of your proposals with commit 27bd8aa. |
|
But not for 'frozen' 1.2.0 -right. This is for 'later' - or? |
|
@musikBear This pull request is made for the |
Add the option to show note values on notes in the Piano Roll. This
functionality is currently coupled with the option "Enable note labels
in piano roll" which can be found in the main menu.
The notes are rendered at about 80% of the notes height. They are only
rendered if they fit on the whole note and if the font does not become
too tiny.
Enable the configuration of the note value text's color via the
stylesheets and set the value to white for both shipped themes.
Other changes: