Update the LMMS logo and mimetypes #4519

Umcaruje · 2018-08-02T18:57:00Z

This has been a project that was long in the making, started it with Rebecca around the time we worked on the new stable-1.2 theme, but the icons were left unfinished in my dropbox folder, until now.

The whole logo was redesigned from scratch, to be flat and fit with the new theme better. All the icons were designed to conform to specific pixel sizes: 16x16x, 24x24, 32x32, 48x48, 64x64, 128x128, and I have also rendered them at double the dpi so they stay sharp on hidpi displays.

Here's the application icon in various sizes:

Here's the application mimetype in various sizes:

Also, I reverted back the changes from e84b537 to now have proper file association inside windows. We embed two icons inside lmms.exe now, one being the app icon, and the other one being the file association icon (mimetype). Also changed the logic inside of the file association code to always rewrite the registry for the new file association entry. A big thank you to @tresf and @PhysSong for helping for this part.

Here are some screenshots on how the mimetype icons look inside of dark and light Arc themes on elementary OS:

And some screenshots of the new icons on macOS:

Also, I updated the mainwindow icon to conform to a 16x16 grid, so it's sharp at a small size. a new icon in the theme was created for this called icon_small

I can't seem to get my VM to work for building windows artefacts, but Tres offered to create an installer so I'll post the windows screenshots soon enough.

Thank you for reading this lengthy post, let me know if you like the new icons!

tresf · 2018-08-02T20:14:29Z

@Umcaruje Is it really so important to have a dozen different resolutions of the mimetype? Does the SVG really render that badly at the various resolutions?

tresf · 2018-08-02T20:36:03Z

Something's wrong with the icon being used for the corner of the Window...

Umcaruje · 2018-08-02T21:54:13Z

Something's wrong with the icon being used for the corner of the Window...

Sorry about that, fixed it

@Umcaruje Is it really so important to have a dozen different resolutions of the mimetype? Does the SVG really render that badly at the various resolutions?

Answered at discord, but lemme answer here too:
Scaling down svg’s to the really small sizes is bound to have artifacts, you can’t expect an icon designed on a 64x64 grid to fit down to 16x16.
I started with one icon and gradually worked it down resolution wise, And I had to tweak the logo every time because it just lands on half pixels when you scale it down.

Example of a rendered scaled svg vs a pixel fitted icon:

Zoomed in, custom icon vs scaled svg:

I do now realise I could probably put svg's inside the specific size folders, but I see that .png's seem to be the standard in any folders other than scalable

PhysSong · 2018-08-05T06:31:41Z

cmake/nsis/FileAssociation.nsh

@@ -128,6 +128,7 @@ NoBackup:
  StrCmp $0 "" 0 Skip
    WriteRegStr HKCR "$R0" "" "$R0"
    WriteRegStr HKCR "$R0\shell" "" "open"
+    WriteRegStr HKCR "$R0\DefaultIcon" "" "$R2,1"


You can move this one line down if you want to always create this key.

So, if I put it under Skip, it will always create it?

So, if I put it under Skip, it will always create it?

I believe SKIP: will only create it on reinstall, never on new install. I wouldn't recommend changing this logic, personally. We need to fix reinstall behavior and this is only a small portion of it. We can just write these settings by hand every time. That's how I do it in other projects.

According to the NSIS documentation, The behavior is:

If $0 is empty(i.e. key $R0 doesn't exist), continue executing

If not(key $R0 already exists), jump to Skip

Thanks. So, what part about my evaluation is incorrect?

You can interpret the StrCmp line as if (strcmp($0,"") != 0) goto Skip;. So lines under the label will always be executed IIUC.

Close, it's if $0 == "" GOTO 0, ELSE GOTO SKIP.

You're right though, Skip is always executed. Sounds good, thanks for explaining!

tresf · 2018-08-06T19:50:35Z

@Umcaruje is the splash screen slated for this change? There is now a slight branding disparity between icon and splash screen.

Umcaruje · 2018-08-08T17:22:03Z

@Umcaruje is the splash screen slated for this change? There is now a slight branding disparity between icon and splash screen.

Yeah, that's true. One of the reasons for the logo update was because the current logo is too detailed for being shown on small sizes. The splash screen is large enough for that detail in the logo to have effect.

I do see it creates a slight branding disparity, but I kind of like it. I'm not sure how I would redesign it.

tresf · 2018-08-08T17:37:18Z

One of the reasons for the logo update was because the current logo is too detailed for being shown on small sizes.

The current logo has no more or less detail than any other icons that I see on Windows, Linux or Mac, so let's call it what it is -- a flattening and rebranding as part of our new theme. :D

I do see it creates a slight branding disparity, but I kind of like it. I'm not sure how I would redesign it.

Ok, if it's going to say, this PR just needs final testing and then it can be merged, right?

Umcaruje · 2018-08-08T17:40:31Z

The current logo has no more or less detail than any other icons that I see on Windows, Linux or Mac, so let's call it what it is -- a flattening and rebranding as part of our new theme. :D

Hahah true 😁

Ok, if it's going to say, this PR just needs final testing and then it can be merged, right?

Yeah, this is ready to merge, I think the windows file association should just be double checked.

tresf · 2018-08-08T19:18:12Z

Yeah, this is ready to merge, I think the windows file association should just be double checked.

I assume you're on this since we fixed your build environment. Let me know if this changes.

Umcaruje · 2018-08-08T19:35:22Z

I assume you're on this since we fixed your build environment. Let me know if this changes.

Yeah, I'm on it

Umcaruje · 2018-08-09T12:37:37Z

Just tested on windows, everything seems to be in perfect order. File association registers even when a previous version is installed. Here are some screenshots:

tresf · 2018-08-09T13:26:26Z

This should be merged. The only concern that I have is that the icon border comes off a bit strong in these two screenshots:

This border does NOT come off as strong at higher resolutions on Windows. @Umcaruje it's your call, but I just wanted to point it out before merging as we'll be living with this new icon for quite a while. :)

PhysSong · 2018-08-26T02:13:16Z

the icon border comes off a bit strong in these two screenshots:

I also think the borders of 16x16 and 24x24 look strong.

PhysSong · 2018-09-06T02:17:04Z

@Umcaruje Are you still on it?

…ion logic

Umcaruje · 2018-09-19T22:26:55Z

Ok, did some rebasing, and updated the icon to have the same border/background combination as the mimetype:

This is how it looks on windows:

Note that I am not finished, I am planing on making custom tiles for windows 10 tomorrow and updating the .icns file for mac.

Also, sorry it took me so long to get to this.

Umcaruje · 2018-09-20T19:41:00Z

Ok, so updates: the icon looks lovely on mac too:

And also, I have added custom artwork for windows 10 tiles:

And the icon looks like this in the start menu:

I also started work on an apple dmg background but I can put that in a new PR, if desired.

tresf · 2018-09-20T19:50:51Z

I also started work on an apple dmg background but I can put that in a new PR, if desired.

Your call. Just add "Closes #4289" in the PR subject if you do it here.

Umcaruje · 2018-09-20T21:46:37Z

Just noticed the small icon was blurry, windows documentation is really weird on this, but I changed the icon to be pixel perfect on 48x48:

jibin1573 · 2018-09-21T03:20:02Z

Lovely tiles!

Umcaruje · 2018-09-24T09:09:31Z

Did another check of all the files, and everything looks good. Merging.

* Update the LMMS logo and mimetypes * fix bmp for nsis installer * Update window and About icons, rename icons, change the file association logic * Fix NSIS * Revert nsh patch * Fix small icon * Always write DefaultIcon in the registry * Fix file permissions * Fix nsis branding * Fix nsis branding LMMS#2 * update the icon windows and linux * Update apple icon, add windows visual manifest * try to fix windows installation * typo * typo 2 * Set small logo to conform to 48x48 grid

PhysSong reviewed Aug 5, 2018

View reviewed changes

PhysSong added enhancement gui in progress and removed gui labels Sep 12, 2018

Umcaruje and others added 10 commits September 19, 2018 23:48

Update the LMMS logo and mimetypes

e6e514e

fix bmp for nsis installer

119d69d

Update window and About icons, rename icons, change the file associat…

56abeb9

…ion logic

Fix NSIS

fd06070

Revert nsh patch

eb6a44e

Fix small icon

0b2b520

Always write DefaultIcon in the registry

3f22840

Fix file permissions

5a652e7

Fix nsis branding

74619d9

Fix nsis branding LMMS#2

9653a91

update the icon windows and linux

2f6d8ad

Umcaruje force-pushed the newicon branch from 49bf157 to 2f6d8ad Compare September 19, 2018 21:49

Umcaruje added 5 commits September 20, 2018 17:45

Update apple icon, add windows visual manifest

dd77c34

try to fix windows installation

74e713a

typo

415c929

typo 2

575cee9

Set small logo to conform to 48x48 grid

ff1eeed

Umcaruje merged commit 8154f88 into LMMS:stable-1.2 Sep 24, 2018

PhysSong mentioned this pull request Nov 15, 2018

Add initial Debian packaging for stable-1.2 #4697

Merged

jasp00 pushed a commit that referenced this pull request Nov 15, 2018

New pixmap as per #4519

55e0d1d

jasp00 added a commit that referenced this pull request Nov 16, 2018

New pixmap as per #4519 (#4708)

c3b07a5

tresf mentioned this pull request Sep 11, 2019

Dynamic branding color for different build types #5166

Draft

9 tasks

sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022

New pixmap as per LMMS#4519 (LMMS#4708)

4cb4a47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the LMMS logo and mimetypes #4519

Update the LMMS logo and mimetypes #4519

Umcaruje commented Aug 2, 2018

tresf commented Aug 2, 2018

tresf commented Aug 2, 2018

Umcaruje commented Aug 2, 2018 •

edited

Loading

PhysSong Aug 5, 2018

Umcaruje Aug 6, 2018

PhysSong Aug 6, 2018

tresf Aug 6, 2018

PhysSong Aug 6, 2018

tresf Aug 6, 2018

PhysSong Aug 6, 2018

tresf Aug 6, 2018

tresf commented Aug 6, 2018

Umcaruje commented Aug 8, 2018

tresf commented Aug 8, 2018

Umcaruje commented Aug 8, 2018

tresf commented Aug 8, 2018

Umcaruje commented Aug 8, 2018

Umcaruje commented Aug 9, 2018

tresf commented Aug 9, 2018

PhysSong commented Aug 26, 2018

PhysSong commented Sep 6, 2018

Umcaruje commented Sep 19, 2018

Umcaruje commented Sep 20, 2018

tresf commented Sep 20, 2018

Umcaruje commented Sep 20, 2018

jibin1573 commented Sep 21, 2018

Umcaruje commented Sep 24, 2018

Update the LMMS logo and mimetypes #4519

Update the LMMS logo and mimetypes #4519

Conversation

Umcaruje commented Aug 2, 2018

tresf commented Aug 2, 2018

tresf commented Aug 2, 2018

Umcaruje commented Aug 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tresf commented Aug 6, 2018

Umcaruje commented Aug 8, 2018

tresf commented Aug 8, 2018

Umcaruje commented Aug 8, 2018

tresf commented Aug 8, 2018

Umcaruje commented Aug 8, 2018

Umcaruje commented Aug 9, 2018

tresf commented Aug 9, 2018

PhysSong commented Aug 26, 2018

PhysSong commented Sep 6, 2018

Umcaruje commented Sep 19, 2018

Umcaruje commented Sep 20, 2018

tresf commented Sep 20, 2018

Umcaruje commented Sep 20, 2018

jibin1573 commented Sep 21, 2018

Umcaruje commented Sep 24, 2018

Umcaruje commented Aug 2, 2018 •

edited

Loading