Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts d599955 and fixes CMake 2 support when building with MingGW. Originally reported by @Umcaruje on
#programming
channel on Discord, CMake 3git blame
discovered by @PhysSong.This patch does not need to be fast-forwarded to
master
branch becausemaster
requires CMake 3 already although it should be at least hand-patched because d599955 was accidentally reverted at some point.Ubuntu 14.04 still defaults to CMake 2 by default (e.g.
apt-get install cmake
), so this can help avoid unobvious dependency issues.Before:
After:
Keywords: