Don't render Automation tracks in the Beat/Bassline #4747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This comment here looks a bit 'off'. lmms/src/core/RenderManager.cpp Line 133 in 5218c1d I think "Don't render Automation Tracks" is probably what was intended. The function commented selects all tracks that aren't muted and which is either an Instrument Track or a Sample Track for rendering. So an Automation Track is treated the same whether it's muted or not. |
|
I've seen nothing problematic with this. Merging this year if no one opposes. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy/paste of related code in
RenderManager::renderTracks()Fixes #4746