Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save/load of PianoRoll marked semitones #5146

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

Veratil
Copy link
Contributor

@Veratil Veratil commented Aug 23, 2019

Related issue #1759

I copied the general format for saving ghost notes, so thanks to the developer(s) who added that. 😄 Additionally I moved the #include "PianoRoll.h" to the top of the include list per new coding conventions.

Copy link
Member

@Reflexe Reflexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! thanks! I'll manually generate installers for your PRs and upload them for testing. Sorry about the delay (we're actively working on a solution for that)

@Reflexe Reflexe self-assigned this Aug 23, 2019
@Reflexe Reflexe added the needs testing This pull request needs more testing label Aug 23, 2019
@Reflexe Reflexe merged commit b07c007 into LMMS:master Sep 14, 2019
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs testing This pull request needs more testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants