fix locking of the useless_lock in LocklessRingBuffer.h #5362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://5601-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.577-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5601?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://5602-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.577-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5602?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://5604-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.577-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/5604?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/3kk26dpan5m8wd8r/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/29862591"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/ikb2lyk34gb1gj8c/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/29862591"}]}, "commit_sha": "958aff90e20cff48dd0b91d686e2f7382be8be72"} |
|
Looks good, and is confirming to docs. Code and style review finished. No testing done yet. |
|
IIRC you say in the #5328 that it had only been crashing on Windows? If yes, then we need a Windows tester. As it's such a simple change though, for me it's just OK without testing, what do you think? |
|
Yes, it crashed only on Windows (that's why we missed it in the spectrum analyzer update review). I tested the Vectorscope build on Windows and this commit fixed the issue. PhysSong also mentioned it fixed "a similar crash" for him, so that should be hopefully a good enough indication that the fix works as intended. |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked bugfix from #5328.