Fixes #3183: Fix file factory delimeter position #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesLorenz
added
needs style review
|
Thank you so much for commenting the code! 🍰 |
|
Separators always appear at expected places in this branch 👍 |
|
Many thanks you two for testing. Only code-review is left now. |
|
I'm starting to grasp the code a bit more now. This looks about right. Style looks fine too. |
zonkmachine
approved these changes
Jan 21, 2020
JohannesLorenz
removed
needs code review
|
Thanks for testing. I'm merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testers
@karmux @zonkmachine Can you please both test this branch (just open LMMS and check some of the delimeters in the file browsers)? With the help of two testers, more file hierarchies are tested.
Code review
Volunteers? ☠️ 😄