New arpeggiator functions - Floor and Ceiling #5521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonkmachine
changed the title
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS
🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://6894-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.710-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6894?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://6897-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.710-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6897?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://6895-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.710-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6895?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/di0ioisp3oxy59rh/artifacts/build/lmms-1.2.1-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/33395666"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/fr3y9eitx656dav4/artifacts/build/lmms-1.2.1-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/33395666"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://6896-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.710-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/6896?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "91d577bb6cb26f73149eb6a91a2f8f4589c0f97d"} |
56 tasks
|
I'm closing this for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some six years later and I'm still revisiting this one from time to time. First proposed in #687
Implements functions 'Floor' and 'Ceiling' proposed in #2080
I made the maxValue of floor and ceil update when the arpeggio model or the range is changed. I also made the ceil value stick to maxValue, if it is at maxValue and the maxValue change, to keep up with the maxValue changing all the time. Those were the biggest issues to solve the last time I touched this code. The last issue is concerning a better gui solution and this is still unsolved.
I have also upgrade the Cycle knob to follow the range.
To do