Remove instrument track window caching to fix related bugs #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes the behavior better when toggling one instrument track mode.
PhysSong
commented
Nov 28, 2020
| delete m_instrumentView; | ||
|
|
||
| if( gui->mainWindow()->workspace() ) | ||
| if (parentWidget()) |
There was a problem hiding this comment.
This is to prevent crashes on closing.
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://1197-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-780%2Bg85a70d1-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1197?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1200-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-780%2Bg85a70d1a4-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1200?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1196-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-780%2Bg85a70d1a4-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1196?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/16rri9l8h6h8mts0/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36570105"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/xycs9mpf3f5rx518/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36570105"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://1199-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-780%2Bg85a70d1a4-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1199?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "85a70d1a407eb6337f3a7291f5f17034527c36cc"} |
|
Give me some time and I'll review this PR. |
JohannesLorenz
requested review from
Veratil and
JohannesLorenz
and removed request for
Veratil
JohannesLorenz
approved these changes
Nov 29, 2020
| @@ -1066,7 +1066,8 @@ InstrumentTrackView::InstrumentTrackView( InstrumentTrack * _it, TrackContainerV | |||
|
|
|||
| InstrumentTrackView::~InstrumentTrackView() | |||
| { | |||
| freeInstrumentTrackWindow(); | |||
| delete m_window; | |||
There was a problem hiding this comment.
What about using unique_ptr instead?
There was a problem hiding this comment.
I think it's out of scope, but it's doable.
IanCaio
pushed a commit
to IanCaio/lmms
that referenced
this pull request
Mar 28, 2021
devnexen
pushed a commit
to devnexen/lmms
that referenced
this pull request
Apr 10, 2021
sdasda7777
pushed a commit
to sdasda7777/lmms
that referenced
this pull request
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3623, fixes #5743.