-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix too small height of the carla instrument window #5829
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://1247-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-792%2Bg266d914-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1247?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://1246-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-792%2Bg266d91409-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1246?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://1248-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-792%2Bg266d91409-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1248?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/mf05ua4a5471qswk/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36681324"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/lt2oogh7q317q9tp/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36681324"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://1250-94782492-gh.circle-artifacts.com/0/lmms-1.2.3-792%2Bg266d91409-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/PhysSong/lmms/1250?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "266d914092e46c945cd1e55c2666342193dc4719"} |
It also affects the behavior of #5827 so they seem related after all. |
How? |
Edit: See post below. |
OK. I get it now. I saw changes in the rest of lmms but this is because once you open one of the Carla instruments, they won't give you back the arrow. It looks like this persists for the rest of the session. Merge? |
Fixes #5828.