Fix possible noise when normalizing bitinvader

[zonkmachine]

Fixes #5867

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.3.0-alpha.1.66%2Bgecef678-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.3.0-alpha.1.66%2Bgecef678be-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha.1.66%2Bgecef678be-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.3.0-alpha-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha-msvc2017-win64.exe (build link)

macOS

• macOS : lmms-1.3.0-alpha.1.66%2Bgecef678be-mac10.14.dmg (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://12146-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.66%2Bgecef678-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12146?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://12150-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.66%2Bgecef678be-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12150?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://12148-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.66%2Bgecef678be-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12148?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/k1efg22n0fuyws8e/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37300521"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/kn4m1o2stf0naw31/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/37300521"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://12149-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.66%2Bgecef678be-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/12149?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "6ebddcac4229da63705047665ca5ebeabf2ae9b4"}

[zonkmachine]

Now the default wave isn't a full sine. Quickest fix for this is to increase the default wave to 200 samples.

[thmueller64]

I tested this PR and it fixes the issue as intended. In the PR above I added an additional check for correct normalization if a similar bug occurs in the future.

[PhysSong]

@zonkmachine Is this ready?

[zonkmachine]

@zonkmachine Is this ready?

Almost there... :)

[zonkmachine]

Tests fine. Problem gone and old projects seem to behave well.

In the PR above I added an additional check for correct normalization if a similar bug occurs in the future.

I've stepped through this code and it looks good to me. Should 7c3213b be squashed with the rest or kept separately at merge?

[zonkmachine]

I think this is ready to merge.

[zonkmachine]

Rebased and pushed manually to master in 04d696a and 4107bc0