Fix issues #6383 and #4410 (pause issues). #6590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madisonsilver
changed the title
DomClark
approved these changes
Dec 22, 2022
PhysSong
reviewed
Dec 29, 2022
PhysSong
requested changes
Jan 3, 2023
This was
linked to
issues
Feb 19, 2023
PhysSong
approved these changes
Feb 19, 2023
|
wow, the second one was convoluted. Took me a bit to realise what was going on. Well, now I know why LMMS was playing notes from a different pattern seemingly at random. I hope this explanation of the bug is sufficient, I gave my best: https://mastodon.social/@LMMS/109920642097039207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to Song.cpp fixes issue #6383.
The change to PianoRoll.cpp fixes issue #4410.