Use C++20 std::numbers, std::lerp() #7696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replace the only use of lmms::numbers::inv_e with a local constexpr instead
They were only used in one or two places each
This is probably not needed for some of these files. I'll remove those later
messmerd
reviewed
Feb 9, 2025
Rest in peace lmms::numbers::tau, my beloved
A lot of the remaining constants in lmms_constants.h are specific to SaProcessor. If they are only used there, shouldn't they be in SaProcessor.h?
|
Almost all the remaining constants in Besides moving Edit: |
- And also move F_EPSILON into lmms_math.h - And also add an overload for fast_rand() to specify a higher and lower bound - And a bunch of other nonsense
As well as time travel to undo several foolish decisions and squash tiny commits together
rubiefawn
force-pushed
the
template-constants2
branch
from
a254925 to
d7a735b
Compare
messmerd
reviewed
Feb 12, 2025
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
messmerd
reviewed
Feb 12, 2025
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
messmerd
approved these changes
Feb 12, 2025
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7558, I added
lmms::numbers; in this PR, I destroy it.<concepts>such asfloating_pointrather thantypenamefor templateslmms::numbersthat are also defined instd::numberswith thestd::numbersversionlmms::numbers::tauwith2 * std::numbers::pi? (I love τ dearly, but @messmerd has a point)lerp()fromlmms_math.handlinearInterpolate()frominterpolation.hwithstd::lerp()(this should have happened in Update math functions to C++ standard library #7685 but I didn't realizestd::lerp()existed)