Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF2/VST Title Fixes, Export Dialog Fixes #808

Merged
merged 4 commits into from
Jun 5, 2014
Merged

SF2/VST Title Fixes, Export Dialog Fixes #808

merged 4 commits into from
Jun 5, 2014

Conversation

tresf
Copy link
Member

@tresf tresf commented Jun 4, 2014

SV2/VST Title Fixes

  • Restores auto-name functionality to newly added SoundFont and VST tracks where the track name will take the name of the soundfont or vst plugin, respectively. This fixes VST/SF2 Title Bug #462 which is a regression bug.
  • Tested on Ubuntu 12.04 and does NOT impact the existing .mmpz, .xpf functionality (maintains compatibility with tracks that have a name specified)

Export Dialog Fixes

  • Parses the (.wav) or (.ogg) from the QFileDialog and appends it as a file extension suffix to the exported file name. This fixes Export as ".wav" does not append extension #764, where the export dialog sometimes is missing this information.
  • Tested on Ubuntu 12.04 and does NOT impact the Export Tracks option.

Testing Results (SF2/VST Title Bug)
Tests were made against stable-1.1 branch, build 1.0.91.
screen shot 2014-06-04 at 9 14 24 am

Testing Results (Export Dialog)
Tests were made against stable-1.1 branch, build 1.0.91.
screen shot 2014-06-04 at 9 15 10 am

screen shot 2014-06-04 at 9 15 27 am

@tobydox
Copy link
Member

tobydox commented Jun 5, 2014

Thanks for all the work and improvements!

tobydox added a commit that referenced this pull request Jun 5, 2014
SF2/VST Title Fixes, Export Dialog Fixes
@tobydox tobydox merged commit dba1e75 into LMMS:stable-1.1 Jun 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants